From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [PATCH v5 01/17] i386: keep hyperv_vendor string up-to-date
Date: Mon, 1 Mar 2021 14:50:47 +0100 [thread overview]
Message-ID: <20210301135103.306003-2-vkuznets@redhat.com> (raw)
In-Reply-To: <20210301135103.306003-1-vkuznets@redhat.com>
When cpu->hyperv_vendor is not set manually we default to "Microsoft Hv"
and in 'hv_passthrough' mode we get the information from the host. This
information is stored in cpu->hyperv_vendor_id[] array but we don't update
cpu->hyperv_vendor string so e.g. QMP's query-cpu-model-expansion output
is incorrect.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
target/i386/cpu.c | 19 +++++++++----------
target/i386/kvm/kvm.c | 5 +++++
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 6a53446e6a56..ee094877d7a1 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6653,17 +6653,16 @@ static void x86_cpu_hyperv_realize(X86CPU *cpu)
/* Hyper-V vendor id */
if (!cpu->hyperv_vendor) {
- memcpy(cpu->hyperv_vendor_id, "Microsoft Hv", 12);
- } else {
- len = strlen(cpu->hyperv_vendor);
-
- if (len > 12) {
- warn_report("hv-vendor-id truncated to 12 characters");
- len = 12;
- }
- memset(cpu->hyperv_vendor_id, 0, 12);
- memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len);
+ object_property_set_str(OBJECT(cpu), "hv-vendor-id", "Microsoft Hv",
+ &error_abort);
+ }
+ len = strlen(cpu->hyperv_vendor);
+ if (len > 12) {
+ warn_report("hv-vendor-id truncated to 12 characters");
+ len = 12;
}
+ memset(cpu->hyperv_vendor_id, 0, 12);
+ memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len);
/* 'Hv#1' interface identification*/
cpu->hyperv_interface_id[0] = 0x31237648;
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 0b5755e42b87..8e9ae7522582 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -1215,6 +1215,11 @@ static int hyperv_handle_properties(CPUState *cs,
cpu->hyperv_vendor_id[0] = c->ebx;
cpu->hyperv_vendor_id[1] = c->ecx;
cpu->hyperv_vendor_id[2] = c->edx;
+ cpu->hyperv_vendor = g_realloc(cpu->hyperv_vendor,
+ sizeof(cpu->hyperv_vendor_id) + 1);
+ memcpy(cpu->hyperv_vendor, cpu->hyperv_vendor_id,
+ sizeof(cpu->hyperv_vendor_id));
+ cpu->hyperv_vendor[sizeof(cpu->hyperv_vendor_id)] = 0;
}
c = cpuid_find_entry(cpuid, HV_CPUID_INTERFACE, 0);
--
2.29.2
next prev parent reply other threads:[~2021-03-01 13:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 13:50 [PATCH v5 00/17] i386: KVM: expand Hyper-V features early and provide simple 'hv-default=on' option Vitaly Kuznetsov
2021-03-01 13:50 ` Vitaly Kuznetsov [this message]
2021-03-01 13:50 ` [PATCH v5 02/17] i386: invert hyperv_spinlock_attempts setting logic with hv_passthrough Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 03/17] i386: always fill Hyper-V CPUID feature leaves from X86CPU data Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 04/17] i386: stop using env->features[] for filling Hyper-V CPUIDs Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 05/17] i386: introduce hyperv_feature_supported() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 06/17] i386: introduce hv_cpuid_get_host() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 07/17] i386: drop FEAT_HYPERV feature leaves Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 08/17] i386: introduce hv_cpuid_cache Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 09/17] i386: split hyperv_handle_properties() into hyperv_expand_features()/hyperv_fill_cpuids() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 10/17] i386: move eVMCS enablement to hyperv_init_vcpu() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 11/17] i386: switch hyperv_expand_features() to using error_setg() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 12/17] i386: adjust the expected KVM_GET_SUPPORTED_HV_CPUID array size Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 13/17] i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's one Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 14/17] i386: use global kvm_state in hyperv_enabled() check Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 15/17] i386: expand Hyper-V features during CPU feature expansion time Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 16/17] i386: provide simple 'hv-default=on' option Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 17/17] qtest/hyperv: Introduce a simple hyper-v test Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301135103.306003-2-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).