qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: [PATCH v5 03/17] i386: always fill Hyper-V CPUID feature leaves from X86CPU data
Date: Mon,  1 Mar 2021 14:50:49 +0100	[thread overview]
Message-ID: <20210301135103.306003-4-vkuznets@redhat.com> (raw)
In-Reply-To: <20210301135103.306003-1-vkuznets@redhat.com>

We have all the required data in X86CPU already and as we are about to
split hyperv_handle_properties() into hyperv_expand_features()/
hyperv_fill_cpuids() we can remove the blind copy. The functional change
is that QEMU won't pass CPUID leaves it doesn't currently know about
to the guest but arguably this is a good change.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 target/i386/kvm/kvm.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 3c1202333d9d..1b1934362a89 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -1207,9 +1207,6 @@ static int hyperv_handle_properties(CPUState *cs,
     }
 
     if (cpu->hyperv_passthrough) {
-        memcpy(cpuid_ent, &cpuid->entries[0],
-               cpuid->nent * sizeof(cpuid->entries[0]));
-
         c = cpuid_find_entry(cpuid, HV_CPUID_VENDOR_AND_MAX_FUNCTIONS, 0);
         if (c) {
             cpu->hyperv_vendor_id[0] = c->ebx;
@@ -1309,12 +1306,6 @@ static int hyperv_handle_properties(CPUState *cs,
         goto free;
     }
 
-    if (cpu->hyperv_passthrough) {
-        /* We already copied all feature words from KVM as is */
-        r = cpuid->nent;
-        goto free;
-    }
-
     c = &cpuid_ent[cpuid_i++];
     c->function = HV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
     c->eax = hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS) ?
-- 
2.29.2



  parent reply	other threads:[~2021-03-01 13:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 13:50 [PATCH v5 00/17] i386: KVM: expand Hyper-V features early and provide simple 'hv-default=on' option Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 01/17] i386: keep hyperv_vendor string up-to-date Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 02/17] i386: invert hyperv_spinlock_attempts setting logic with hv_passthrough Vitaly Kuznetsov
2021-03-01 13:50 ` Vitaly Kuznetsov [this message]
2021-03-01 13:50 ` [PATCH v5 04/17] i386: stop using env->features[] for filling Hyper-V CPUIDs Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 05/17] i386: introduce hyperv_feature_supported() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 06/17] i386: introduce hv_cpuid_get_host() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 07/17] i386: drop FEAT_HYPERV feature leaves Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 08/17] i386: introduce hv_cpuid_cache Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 09/17] i386: split hyperv_handle_properties() into hyperv_expand_features()/hyperv_fill_cpuids() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 10/17] i386: move eVMCS enablement to hyperv_init_vcpu() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 11/17] i386: switch hyperv_expand_features() to using error_setg() Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 12/17] i386: adjust the expected KVM_GET_SUPPORTED_HV_CPUID array size Vitaly Kuznetsov
2021-03-01 13:50 ` [PATCH v5 13/17] i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's one Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 14/17] i386: use global kvm_state in hyperv_enabled() check Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 15/17] i386: expand Hyper-V features during CPU feature expansion time Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 16/17] i386: provide simple 'hv-default=on' option Vitaly Kuznetsov
2021-03-01 13:51 ` [PATCH v5 17/17] qtest/hyperv: Introduce a simple hyper-v test Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210301135103.306003-4-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).