From: Greg Kurz <groug@kaod.org>
To: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 4/5] spapr_pci.c: add 'unplug already in progress' message for PCI unplug
Date: Mon, 1 Mar 2021 15:14:26 +0100 [thread overview]
Message-ID: <20210301151426.5ba252e5@bahia.lan> (raw)
In-Reply-To: <20210226163301.419727-5-danielhb413@gmail.com>
On Fri, 26 Feb 2021 13:33:00 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
> Hotunplug for all other devices are warning the user when the hotunplug
> is already in progress. Do the same for PCI devices in
> spapr_pci_unplug_request().
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> hw/ppc/spapr_pci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index b00e9609ae..feba18cb12 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1743,6 +1743,10 @@ static void spapr_pci_unplug_request(HotplugHandler *plug_handler,
> }
> }
> }
> + } else {
> + error_setg(errp,
> + "PCI device unplug already in progress for device %s",
> + drc->dev->id);
> }
> }
>
next prev parent reply other threads:[~2021-03-01 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:32 [PATCH 0/5] send QAPI_EVENT_MEM_UNPLUG_ERROR for ppc64 unplugs Daniel Henrique Barboza
2021-02-26 16:32 ` [PATCH 1/5] spapr.c: assert first DRC LMB earlier in spapr_memory_unplug_request() Daniel Henrique Barboza
2021-03-01 14:11 ` Greg Kurz
2021-02-26 16:32 ` [PATCH 2/5] spapr.c: check unplug_request flag " Daniel Henrique Barboza
2021-03-01 14:13 ` Greg Kurz
2021-03-02 2:03 ` David Gibson
2021-03-02 10:39 ` Daniel Henrique Barboza
2021-02-26 16:32 ` [PATCH 3/5] spapr.c: add 'unplug already in progress' message for PHB unplug Daniel Henrique Barboza
2021-03-01 14:14 ` Greg Kurz
2021-03-02 2:06 ` David Gibson
2021-02-26 16:33 ` [PATCH 4/5] spapr_pci.c: add 'unplug already in progress' message for PCI unplug Daniel Henrique Barboza
2021-03-01 14:14 ` Greg Kurz [this message]
2021-03-02 2:08 ` David Gibson
2021-02-26 16:33 ` [PATCH 5/5] spapr.c: send QAPI event when memory hotunplug fails Daniel Henrique Barboza
2021-03-01 14:19 ` Greg Kurz
2021-03-02 2:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301151426.5ba252e5@bahia.lan \
--to=groug@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).