From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/2] storage-daemon: include current command line option in the errors
Date: Mon, 1 Mar 2021 19:24:08 +0100 [thread overview]
Message-ID: <20210301182408.GI7698@merkur.fritz.box> (raw)
In-Reply-To: <20210301152844.291799-1-pbonzini@redhat.com>
Am 01.03.2021 um 16:28 hat Paolo Bonzini geschrieben:
> Use the location management facilities that the emulator uses, so that
> the current command line option appears in the error message.
>
> Before:
>
> $ storage-daemon/qemu-storage-daemon --nbd key..=
> qemu-storage-daemon: Invalid parameter 'key..'
>
> After:
>
> $ storage-daemon/qemu-storage-daemon --nbd key..=
> qemu-storage-daemon: --nbd key..=: Invalid parameter 'key..'
>
> The first patch tweaks the command line parsing so that argv is
> not reordered by getopt_long and optind is only advanced by one
> option+argument on every call to getopt_long. This is required
> by loc_set_cmdline.
Thanks, very useful to know about the "-" switch in getopts.
Applied to the block branch.
Kevin
prev parent reply other threads:[~2021-03-01 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 15:28 [PATCH v2 0/2] storage-daemon: include current command line option in the errors Paolo Bonzini
2021-03-01 15:28 ` [PATCH v2 1/2] storage-daemon: report unexpected arguments on the fly Paolo Bonzini
2021-03-01 15:38 ` Eric Blake
2021-03-01 16:29 ` Paolo Bonzini
2021-03-02 6:33 ` Markus Armbruster
2021-03-01 15:28 ` [PATCH v2 2/2] storage-daemon: include current command line option in the errors Paolo Bonzini
2021-03-02 6:38 ` Markus Armbruster
2021-03-01 18:24 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301182408.GI7698@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).