[PATCH] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[PATCH] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[Philippe Mathieu-Daudé]

TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
requires APM to be selected.

Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/isa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index c7f07854f7e..9c026d0c510 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -47,6 +47,7 @@ config VT82C686
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC
+    select APM
 
 config SMC37C669
     bool
-- 
2.26.2

Re: [PATCH] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[Philippe Mathieu-Daudé]

ping for review?

On 3/2/21 9:05 AM, Philippe Mathieu-Daudé wrote:
> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
> requires APM to be selected.
> 
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/isa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index c7f07854f7e..9c026d0c510 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -47,6 +47,7 @@ config VT82C686
>      select ACPI_SMBUS
>      select SERIAL_ISA
>      select FDC
> +    select APM
>  
>  config SMC37C669
>      bool
> 

Re: [PATCH] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[BALATON Zoltan]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote:
> ping for review?

This is included in my pegasos2 series as 6/8 replacing half of a similar 
patch from my original version. Since I've reported it I don't think I 
should be also reviewing it but it's quite trivial so may not need that 
much review.

Regards,
BALATON Zoltan

> On 3/2/21 9:05 AM, Philippe Mathieu-Daudé wrote:
>> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
>> requires APM to be selected.
>>
>> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  hw/isa/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>> index c7f07854f7e..9c026d0c510 100644
>> --- a/hw/isa/Kconfig
>> +++ b/hw/isa/Kconfig
>> @@ -47,6 +47,7 @@ config VT82C686
>>      select ACPI_SMBUS
>>      select SERIAL_ISA
>>      select FDC
>> +    select APM
>>
>>  config SMC37C669
>>      bool
>>
>
>

Re: [PATCH] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[Philippe Mathieu-Daudé]

On 3/10/21 12:41 AM, BALATON Zoltan wrote:
> On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote:
>> ping for review?
> 
> This is included in my pegasos2 series as 6/8 replacing half of a
> similar patch from my original version. Since I've reported it I don't
> think I should be also reviewing it but it's quite trivial so may not
> need that much review.

Forwarding a patch doesn't mean you have reviewed it :/

If you can provide a formal R-b tag, then I can queue this or the
one in your series.

Thanks,

Phil.

Re: [PATCH] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

[BALATON Zoltan]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On Wed, 10 Mar 2021, Philippe Mathieu-Daudé wrote:
> On 3/10/21 12:41 AM, BALATON Zoltan wrote:
>> On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote:
>>> ping for review?
>>
>> This is included in my pegasos2 series as 6/8 replacing half of a
>> similar patch from my original version. Since I've reported it I don't
>> think I should be also reviewing it but it's quite trivial so may not
>> need that much review.
>
> Forwarding a patch doesn't mean you have reviewed it :/

I guess it does mean I agree with it and really don't see how another line 
with my name would make it any better when it already has my Suggested-by 
and Signed-off-by. An R-b tag probably really only helps for patches that 
are more complex than one line that the maintainter can easily check.

> If you can provide a formal R-b tag, then I can queue this or the
> one in your series.

The two are the same. If you commit this first my series can be easily 
rebased by dropping that patch or it will get committed as part of the 
series. At this point I think it's easiest if David takes the whole series 
than if you take a few of them then I have to rebase again and part of the 
series goes in via another tree. As the freeze is nearing I'd like 
somebody take the whole series so if you can ack the vt82c686 parts I 
think you don't need to do anything more which is what you said before 
you'd prefer.

I'll fix the errp you've noticed and repost. Adding any more to the series 
now would need starting review again which would risk missing the freeze. 
So unless it's needed to accept the series as it is I'd leave any other 
improvements for later after this pegasos2 series is merged.

Regards,
BALATON Zoltan

> Thanks,
>
> Phil.
>
>