From: Minwoo Im <minwoo.im.dev@gmail.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Klaus Jensen <k.jensen@samsung.com>,
Max Reitz <mreitz@redhat.com>, Klaus Jensen <its@irrelevant.dk>,
Minwoo Im <minwoo.im.dev@gmail.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCH V4 2/8] hw/block/nvme: fix namespaces array to 1-based
Date: Tue, 2 Mar 2021 22:26:11 +0900 [thread overview]
Message-ID: <20210302132617.18495-3-minwoo.im.dev@gmail.com> (raw)
In-Reply-To: <20210302132617.18495-1-minwoo.im.dev@gmail.com>
subsys->namespaces array used to be sized to NVME_SUBSYS_MAX_NAMESPACES.
But subsys->namespaces are being accessed with 1-based namespace id
which means the very first array entry will always be empty(NULL).
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Tested-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/block/nvme-subsys.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme-subsys.h b/hw/block/nvme-subsys.h
index 890d118117dc..574774390c4c 100644
--- a/hw/block/nvme-subsys.h
+++ b/hw/block/nvme-subsys.h
@@ -24,7 +24,7 @@ typedef struct NvmeSubsystem {
NvmeCtrl *ctrls[NVME_SUBSYS_MAX_CTRLS];
/* Allocated namespaces for this subsystem */
- NvmeNamespace *namespaces[NVME_SUBSYS_MAX_NAMESPACES];
+ NvmeNamespace *namespaces[NVME_SUBSYS_MAX_NAMESPACES + 1];
} NvmeSubsystem;
int nvme_subsys_register_ctrl(NvmeCtrl *n, Error **errp);
--
2.27.0
next prev parent reply other threads:[~2021-03-02 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 13:26 [PATCH V4 0/8] hw/block/nvme: support namespace attachment Minwoo Im
2021-03-02 13:26 ` [PATCH V4 1/8] hw/block/nvme: support namespace detach Minwoo Im
2021-03-02 13:26 ` Minwoo Im [this message]
2021-03-02 13:26 ` [PATCH V4 3/8] hw/block/nvme: fix allocated namespace list to 256 Minwoo Im
2021-03-02 13:26 ` [PATCH V4 4/8] hw/block/nvme: support allocated namespace type Minwoo Im
2021-03-02 13:26 ` [PATCH V4 5/8] hw/block/nvme: refactor nvme_select_ns_iocs Minwoo Im
2021-03-02 13:26 ` [PATCH V4 6/8] hw/block/nvme: support namespace attachment command Minwoo Im
2021-03-02 13:26 ` [PATCH V4 7/8] hw/block/nvme: support changed namespace asyncrohous event Minwoo Im
2021-03-02 13:26 ` [PATCH V4 8/8] hw/block/nvme: support Identify NS Attached Controller List Minwoo Im
2021-03-04 19:33 ` [PATCH V4 0/8] hw/block/nvme: support namespace attachment Keith Busch
2021-03-08 11:30 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302132617.18495-3-minwoo.im.dev@gmail.com \
--to=minwoo.im.dev@gmail.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).