From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: afrosi@redhat.com, Daniel Berrange <berrange@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Richard W . M . Jones" <rjones@redhat.com>
Subject: Re: [PATCH v2] qemu-storage-daemon: add --pidfile option
Date: Tue, 2 Mar 2021 14:57:47 +0100 [thread overview]
Message-ID: <20210302135747.GA5527@merkur.fritz.box> (raw)
In-Reply-To: <20210302092926.163080-1-stefanha@redhat.com>
Am 02.03.2021 um 10:29 hat Stefan Hajnoczi geschrieben:
> Daemons often have a --pidfile option where the pid is written to a file
> so that scripts can stop the daemon by sending a signal.
>
> The pid file also acts as a lock to prevent multiple instances of the
> daemon from launching for a given pid file.
>
> QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helper all support the
> --pidfile option. Add it to qemu-storage-daemon too.
>
> Reported-by: Richard W.M. Jones <rjones@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
I think we should also mention --pidfile in the --help output.
Kevin
prev parent reply other threads:[~2021-03-02 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:29 [PATCH v2] qemu-storage-daemon: add --pidfile option Stefan Hajnoczi
2021-03-02 10:32 ` Daniel P. Berrangé
2021-03-02 11:49 ` Richard W.M. Jones
2021-03-02 13:57 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302135747.GA5527@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=afrosi@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).