qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, "Thomas Huth" <thuth@redhat.com>,
	berrange@redhat.com, "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	f4bug@amsat.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Daniele Buono" <dbuono@linux.vnet.ibm.com>,
	stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	aurelien@aurel32.net
Subject: [PATCH  v1 7/9] gitlab-ci.yml: Allow custom # of parallel linkers
Date: Fri,  5 Mar 2021 09:23:26 +0000	[thread overview]
Message-ID: <20210305092328.31792-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210305092328.31792-1-alex.bennee@linaro.org>

From: Daniele Buono <dbuono@linux.vnet.ibm.com>

Define a new variable LD_JOBS, that can be used to select
the maximum number of linking jobs to be executed in parallel.
If the variable is not defined, maintain the default given by
make -j

Currently, make parallelism at build time is based on the number
of cpus available.

This doesn't work well with LTO at linking, because with LTO the
linker has to load in memory all the intermediate object files
for optimization.
The end result is that, if the gitlab runner happens to run two
linking processes at the same time, the job will fail with an
out-of-memory error,

This patch leverages the ability to maintain high parallelism at
compile time, but limit the number of linkers executed in parallel.

Signed-off-by: Daniele Buono <dbuono@linux.vnet.ibm.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210304030948.9367-2-dbuono@linux.vnet.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .gitlab-ci.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c2c5196b8b..1ea944eb91 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -27,6 +27,10 @@ include:
       else
         ../configure --enable-werror $CONFIGURE_ARGS ;
       fi || { cat config.log meson-logs/meson-log.txt && exit 1; }
+    - if test -n "$LD_JOBS";
+      then
+        meson configure . -Dbackend_max_links="$LD_JOBS" ;
+      fi || exit 1;
     - make -j"$JOBS"
     - if test -n "$MAKE_CHECK_ARGS";
       then
-- 
2.20.1



  parent reply	other threads:[~2021-03-05  9:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:23 [PATCH v1 0/9] testing/next (docs, hexagon, cfi, docker) Alex Bennée
2021-03-05  9:23 ` [PATCH v1 1/9] docs/devel: re-organise the developers guide into sections Alex Bennée
2021-03-05  9:40   ` Philippe Mathieu-Daudé
2021-03-05 13:37     ` Alex Bennée
2021-03-05  9:23 ` [PATCH v1 2/9] docs/system: add a gentle prompt for the complexity to come Alex Bennée
2021-03-05  9:23 ` [PATCH v1 3/9] tests/docker: add a test-tcg for building then running check-tcg Alex Bennée
2021-03-05  9:41   ` Philippe Mathieu-Daudé
2021-03-05  9:23 ` [PATCH v1 4/9] docker: Add Hexagon image Alex Bennée
2021-03-05  9:23 ` [PATCH v1 5/9] tests/tcg: Use Hexagon Docker image Alex Bennée
2021-03-05  9:23 ` [PATCH v1 6/9] gitlab: add build-user-hexagon test Alex Bennée
2021-03-05  9:43   ` Philippe Mathieu-Daudé
2021-03-05 15:37   ` Wainer dos Santos Moschetta
2021-03-05  9:23 ` Alex Bennée [this message]
2021-03-05  9:23 ` [PATCH v1 8/9] gitlab-ci.yml: Add jobs to test CFI flags Alex Bennée
2021-03-05  9:43   ` Philippe Mathieu-Daudé
2021-03-05  9:23 ` [PATCH v1 9/9] tests/docker: Use --arch-only when building Debian cross image Alex Bennée
2021-03-05  9:42 ` [PATCH v1 0/9] testing/next (docs, hexagon, cfi, docker) no-reply
2021-03-05 19:37 ` Willian Rampazzo
2021-03-07 17:29   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305092328.31792-8-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=dbuono@linux.vnet.ibm.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).