From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: [PULL 07/14] scripts/ci/gitlab-pipeline-status: give more information on failures
Date: Tue, 9 Mar 2021 11:46:10 +0100 [thread overview]
Message-ID: <20210309104617.714908-8-thuth@redhat.com> (raw)
In-Reply-To: <20210309104617.714908-1-thuth@redhat.com>
From: Cleber Rosa <crosa@redhat.com>
When an HTTP GET request fails, it's useful to go beyond the "not
successful" message, and show the code returned by the server.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210222193240.921250-3-crosa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/ci/gitlab-pipeline-status | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
index 0c1e8bd8a7..ad62ab3cfc 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -56,7 +56,9 @@ def get_json_http_response(url):
connection.request('GET', url=url)
response = connection.getresponse()
if response.code != http.HTTPStatus.OK:
- raise CommunicationFailure("Failed to receive a successful response")
+ msg = "Received unsuccessful response: %s (%s)" % (response.code,
+ response.reason)
+ raise CommunicationFailure(msg)
return json.loads(response.read())
--
2.27.0
next prev parent reply other threads:[~2021-03-09 10:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 10:46 [PULL 00/14] Gitlab, testing and misc patches Thomas Huth
2021-03-09 10:46 ` [PULL 01/14] qtest: delete superfluous inclusions of qtest.h Thomas Huth
2021-03-09 10:46 ` [PULL 02/14] docker: Alpine build job depends on Alpine container Thomas Huth
2021-03-09 10:46 ` [PULL 03/14] docker: EDK2 build job depends on EDK2 container Thomas Huth
2021-03-09 10:46 ` [PULL 04/14] docker: OpenSBI build job depends on OpenSBI container Thomas Huth
2021-03-09 10:46 ` [PULL 05/14] meson: Re-enable the possibility to run "make check SPEED=slow" Thomas Huth
2021-03-09 10:46 ` [PULL 06/14] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET Thomas Huth
2021-03-09 10:46 ` Thomas Huth [this message]
2021-03-09 10:46 ` [PULL 08/14] scripts/ci/gitlab-pipeline-status: give more info when pipeline not found Thomas Huth
2021-03-09 10:46 ` [PULL 09/14] libqos/qgraph: format qgraph comments for sphinx documentation Thomas Huth
2021-03-09 10:46 ` [PULL 10/14] docs/devel/qgraph: improve qgraph documentation Thomas Huth
2021-03-09 10:46 ` [PULL 11/14] Acceptance Tests: restore downloading of VM images Thomas Huth
2021-03-09 10:46 ` [PULL 12/14] Acceptance Tests: restore filtering of tests by target arch Thomas Huth
2021-03-09 10:46 ` [PULL 13/14] Remove deprecated target tilegx Thomas Huth
2021-03-09 10:46 ` [PULL 14/14] bsd-user: Add new maintainers Thomas Huth
2021-03-09 11:06 ` [PULL 00/14] Gitlab, testing and misc patches no-reply
2021-03-10 20:11 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309104617.714908-8-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).