From: Peter Xu <peterx@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, jean-philippe@linaro.org,
jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
shameerali.kolothum.thodi@huawei.com, vivek.gautam@arm.com,
qemu-arm@nongnu.org, pbonzini@redhat.com,
eric.auger.pro@gmail.com
Subject: Re: [PATCH v3 2/7] dma: Introduce dma_aligned_pow2_mask()
Date: Tue, 9 Mar 2021 11:28:26 -0500 [thread overview]
Message-ID: <20210309162826.GC763132@xz-x1> (raw)
In-Reply-To: <20210309102742.30442-3-eric.auger@redhat.com>
On Tue, Mar 09, 2021 at 11:27:37AM +0100, Eric Auger wrote:
> Currently get_naturally_aligned_size() is used by the intel iommu
> to compute the maximum invalidation range based on @size which is
> a power of 2 while being aligned with the @start address and less
> than the maximum range defined by @gaw.
>
> This helper is also useful for other iommu devices (virtio-iommu,
> SMMUv3) to make sure IOMMU UNMAP notifiers only are called with
> power of 2 range sizes.
>
> Let's move this latter into dma-helpers.c and rename it into
> dma_aligned_pow2_mask(). Also rewrite the helper so that it
> accomodates UINT64_MAX values for the size mask and max mask.
> It now returns a mask instead of a size. Change the caller.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-03-09 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 10:27 [PATCH v3 0/7] Some vIOMMU fixes Eric Auger
2021-03-09 10:27 ` [PATCH v3 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate Eric Auger
2021-03-09 10:27 ` [PATCH v3 2/7] dma: Introduce dma_aligned_pow2_mask() Eric Auger
2021-03-09 16:28 ` Peter Xu [this message]
2021-03-09 10:27 ` [PATCH v3 3/7] virtio-iommu: Handle non power of 2 range invalidations Eric Auger
2021-03-09 10:27 ` [PATCH v3 4/7] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set Eric Auger
2021-03-09 10:27 ` [PATCH v3 5/7] hw/arm/smmuv3: Enforce invalidation on a power of two range Eric Auger
2021-03-09 10:27 ` [PATCH v3 6/7] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling Eric Auger
2021-03-25 14:18 ` Zenghui Yu
2021-03-25 15:09 ` Auger Eric
2021-03-26 2:23 ` Zenghui Yu
2021-03-09 10:27 ` [PATCH v3 7/7] hw/arm/smmuv3: Uniformize sid traces Eric Auger
2021-03-11 13:22 ` [PATCH v3 0/7] Some vIOMMU fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309162826.GC763132@xz-x1 \
--to=peterx@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=vivek.gautam@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).