From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09C1BC433DB for ; Tue, 9 Mar 2021 20:44:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5BC86523A for ; Tue, 9 Mar 2021 20:44:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5BC86523A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJjDr-0006MO-Md for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 15:44:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJibF-0000jS-FA for qemu-devel@nongnu.org; Tue, 09 Mar 2021 15:05:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJibB-0007Mi-HJ for qemu-devel@nongnu.org; Tue, 09 Mar 2021 15:05:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615320295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9VnVJw0mUoWlvR4oUcurQR1ID0ATTbgo0v9El6/2vw4=; b=Mg7LG8GJWDbywTFJiA54OlaE1CgaHlM0MF3+Id4S7srz6hXNogHNshkfst9W5W6A9/2D85 obOVK4l6osgJmCg4LQbUjP2KnBTcyq+WRbjXmQaMTOFSsOp4GR0hX6hwnCUwyMW7G2Nf9N oKBpQj070ByqWfCxdyspVbZs8ea/RPk= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-9UBT1qRwN9-8AA8lY2tMSQ-1; Tue, 09 Mar 2021 15:04:54 -0500 X-MC-Unique: 9UBT1qRwN9-8AA8lY2tMSQ-1 Received: by mail-qt1-f198.google.com with SMTP id 4so11283618qtc.13 for ; Tue, 09 Mar 2021 12:04:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9VnVJw0mUoWlvR4oUcurQR1ID0ATTbgo0v9El6/2vw4=; b=TAGx0+6vaXNAGP2N4ml5U0ERfsnWPhDbxGrk/QdmmDpeb+nnyUrK75GaAsQIK+1qB7 beDif/YtTe5OPp0Ze7lWuz7Eop3j1sGEP26OoWqmV2u2orz9b0uA1wzA9ngv5qxGMacc hrYgTPY1RT7+dAibsj8Y5jMK7Oum5gojI4tHbExkradrDSpgcxmPrWxm4A1IYkA6MkS9 eLtr3VOBh6zCxJC12RleXFBl/0vX9neKcyRShulEh2SniWdBzN/ugWCk3HvrHefqfBur Ls85oq1IN+vXK+hSDbu80X6k/8Awr+HT6TTOs9tVA1eRiIXpzo21VzrZArhbEMgrrABV HokQ== X-Gm-Message-State: AOAM5334rlFr8qs79m+JPEyPzVHQvgLRydlkI8dr0OhOBgtVM6TYcozN 7qvxAils3VVAyjURQZSOfo7WZeTuTrY0PR3PvDhwvzVB5dk/jxSUX5xRMAvEYYdGqWlOd4jt4// g4zi5OiV+BZ2Yts8= X-Received: by 2002:a05:6214:d6d:: with SMTP id 13mr27959095qvs.60.1615320293519; Tue, 09 Mar 2021 12:04:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0h6rCjsz6FpCKiQEzasdyob+Shl4vJoiLU/3F8aRwydS8NqDicavzN+seGBeRkSkBF+pcgQ== X-Received: by 2002:a05:6214:d6d:: with SMTP id 13mr27959080qvs.60.1615320293314; Tue, 09 Mar 2021 12:04:53 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-25-174-95-95-253.dsl.bell.ca. [174.95.95.253]) by smtp.gmail.com with ESMTPSA id f9sm9469319qkk.115.2021.03.09.12.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 12:04:52 -0800 (PST) Date: Tue, 9 Mar 2021 15:04:51 -0500 From: Peter Xu To: David Hildenbrand Subject: Re: [PATCH v3 09/12] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap() Message-ID: <20210309200451.GF763132@xz-x1> References: <20210308150600.14440-1-david@redhat.com> <20210308150600.14440-10-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210308150600.14440-10-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Cornelia Huck , Eduardo Habkost , "Michael S. Tsirkin" , Stefan Weil , Murilo Opsfelder Araujo , Richard Henderson , "Dr. David Alan Gilbert" , Juan Quintela , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , Greg Kurz , Stefan Hajnoczi , Igor Mammedov , Thomas Huth , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Igor Kotrasinski Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 08, 2021 at 04:05:57PM +0100, David Hildenbrand wrote: > Let's introduce a new set of flags that abstract mmap logic and replace > our current set of bools, to prepare for another flag. > > Signed-off-by: David Hildenbrand > --- > include/qemu/mmap-alloc.h | 17 +++++++++++------ > softmmu/physmem.c | 8 +++++--- > util/mmap-alloc.c | 14 +++++++------- > util/oslib-posix.c | 3 ++- > 4 files changed, 25 insertions(+), 17 deletions(-) > > diff --git a/include/qemu/mmap-alloc.h b/include/qemu/mmap-alloc.h > index 456ff87df1..55664ea9f3 100644 > --- a/include/qemu/mmap-alloc.h > +++ b/include/qemu/mmap-alloc.h > @@ -6,6 +6,15 @@ size_t qemu_fd_getpagesize(int fd); > > size_t qemu_mempath_getpagesize(const char *mem_path); > > +/* Map PROT_READ instead of PROT_READ|PROT_WRITE. */ > +#define QEMU_RAM_MMAP_READONLY (1 << 0) > + > +/* Map MAP_SHARED instead of MAP_PRIVATE. */ > +#define QEMU_RAM_MMAP_SHARED (1 << 1) > + > +/* Map MAP_SYNC|MAP_SHARED_VALIDATE if possible, fallback and warn otherwise. */ > +#define QEMU_RAM_MMAP_PMEM (1 << 2) Sorry to speak late - I just noticed that is_pmem can actually be converted too with "MAP_SYNC | MAP_SHARED_VALIDATE". We can even define MAP_PMEM_EXTRA for use within qemu if we want. Then we can avoid one layer of QEMU_RAM_* by directly using MAP_*, I think? -- Peter Xu