From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH] tests: Fix broken "make check-speed"
Date: Wed, 10 Mar 2021 10:49:36 +0100 [thread overview]
Message-ID: <20210310094936.1318317-1-thuth@redhat.com> (raw)
When running "make check-speed", currently nothing happens. This is
because the redirection to "bench-speed" is not working as expected
(since the bench-speed rule in the generated Makefile.mtest filters
for "bench-speed" and "bench" in the MAKECMDGOALS variable).
Fix it by calling "make bench-speed" instead of using a dependency.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/Makefile.include | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index d34254fb29..2a43cce4f6 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -134,7 +134,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) get-vm-images
# Consolidated targets
-.PHONY: check-block check check-clean get-vm-images
+.PHONY: check-block check check-clean get-vm-images check-speed
check:
ifeq ($(CONFIG_TOOLS)$(CONFIG_POSIX),yy)
@@ -156,6 +156,7 @@ clean: check-clean
# For backwards compatibility
-check-speed: bench-speed
+check-speed:
+ $(MAKE) bench-speed
endif
--
2.27.0
next reply other threads:[~2021-03-10 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:49 Thomas Huth [this message]
2021-03-10 15:49 ` [PATCH] tests: Fix broken "make check-speed" Willian Rampazzo
2021-03-10 16:04 ` Paolo Bonzini
2021-03-10 16:08 ` Willian Rampazzo
2021-03-10 16:38 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310094936.1318317-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).