qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>, "Bandan Das" <bsd@redhat.com>,
	"Prasad J Pandit" <ppandit@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [RFC PATCH 2/3] tests/test-blockjob: Use zeroes-co instead of null-co, read-zeroes=on
Date: Wed, 10 Mar 2021 12:43:13 +0100	[thread overview]
Message-ID: <20210310114314.1068957-3-philmd@redhat.com> (raw)
In-Reply-To: <20210310114314.1068957-1-philmd@redhat.com>

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
RFC because I won't convert the rest of the tests until the
previous patch is reviewed.
---
 tests/test-blockjob.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c
index 75198479120..ae2ea7028ee 100644
--- a/tests/test-blockjob.c
+++ b/tests/test-blockjob.c
@@ -70,9 +70,7 @@ static BlockBackend *create_blk(const char *name)
     BlockBackend *blk = blk_new(qemu_get_aio_context(), 0, BLK_PERM_ALL);
     BlockDriverState *bs;
 
-    QDict *opt = qdict_new();
-    qdict_put_str(opt, "file.read-zeroes", "on");
-    bs = bdrv_open("null-co://", NULL, opt, 0, &error_abort);
+    bs = bdrv_open("zeroes-co://", NULL, NULL, 0, &error_abort);
     g_assert_nonnull(bs);
 
     blk_insert_bs(blk, bs, &error_abort);
-- 
2.26.2



  parent reply	other threads:[~2021-03-10 11:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 11:43 [PATCH 0/3] block: Introduce the 'zeroes-co' driver to help security reports Philippe Mathieu-Daudé
2021-03-10 11:43 ` [PATCH 1/3] block: Introduce the 'zeroes-co' driver Philippe Mathieu-Daudé
2021-03-10 11:43 ` Philippe Mathieu-Daudé [this message]
2021-03-10 11:43 ` [PATCH 3/3] docs/secure-coding-practices: Describe null-co/zeroes-co block drivers Philippe Mathieu-Daudé
2021-03-10 12:40   ` Vladimir Sementsov-Ogievskiy
2021-03-10 11:55 ` [PATCH 0/3] block: Introduce the 'zeroes-co' driver to help security reports Daniel P. Berrangé
2021-03-10 12:29   ` Philippe Mathieu-Daudé
2021-03-10 12:32 ` Fam Zheng
2021-03-10 12:37   ` Philippe Mathieu-Daudé
2021-03-10 14:24     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310114314.1068957-3-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=bsd@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).