From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E3B8C433E0 for ; Wed, 10 Mar 2021 18:37:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3A2064F9A for ; Wed, 10 Mar 2021 18:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A2064F9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK3i8-0002Tu-Mz for qemu-devel@archiver.kernel.org; Wed, 10 Mar 2021 13:37:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK3ca-0005Vd-QE for qemu-devel@nongnu.org; Wed, 10 Mar 2021 13:31:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lK3cZ-00039B-6Q for qemu-devel@nongnu.org; Wed, 10 Mar 2021 13:31:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615401106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q5DY/aN4CG9GqGVr+tCHRu+SWwcj5rYLvRE4za5fNpY=; b=FV2Tzk7Xk0iQ8Uasf+BiLCtNLVXMXvmQVaDpE+BYpU2QGsVeaq/aGohumQXNR4rzMO2vDe +7b/wFJPgkD8LU0D3YN7vTjP5hctnlbnWLPJpFVnKi6m684ZF9kVd44AAEdjNpCr5LGQsY 2ifVQq0816qFNNdWJtVO1lhdQxvAoUg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-GFwgh4BtOhmy_Caf-BPJZw-1; Wed, 10 Mar 2021 13:31:43 -0500 X-MC-Unique: GFwgh4BtOhmy_Caf-BPJZw-1 Received: by mail-ej1-f71.google.com with SMTP id en21so7622596ejc.2 for ; Wed, 10 Mar 2021 10:31:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q5DY/aN4CG9GqGVr+tCHRu+SWwcj5rYLvRE4za5fNpY=; b=DGxOrxZQIweJi+T5E5YWy/n6XEbirGATFjZRmRsMhFt1qAzBFoEqfAG061yrUYDEWt ofATLs18+U3y8bcU2v5XiyiZXoS5EdH7cgRO7fV96WFH1gJ6ApgAyP9Yj/GVldMxFUea Bk7m8+hSw55JjjVjMyaRCWyzLcgULTSeKu3V4kkfv0mG9PVa+QawZu7HvlpOKyJYWEG7 FhwmCa9RghscXXhHlQtaJCD0THGHEw/i80cpYjUF8+VJwzU1iCtCAwI9HDLKh1+EXh1P l762KQK83DT7bIh8MB+F8SL8g2i14u2vUsQrEzYkTtTpO8X1BaATNIZ1Y7N1L45bx2MX nZmg== X-Gm-Message-State: AOAM532cfK2JXj0jv+bxtb1YDVLZLGFrq4qVNoZToinNVFYVdqNbRF8b ctdhXETXnPhZXu7oPWZeUSDr/E5Qt2U2P/vgpOKiXwgcerSqJ7ie+lBcqjbnArQyuDHqraS6+4z wC8q2+UmqfKqTS26q3KQW0lknl6V5qDZu60gHB2owwis+YWKxhZjhL2Qrmqvt7yGg X-Received: by 2002:a17:907:9709:: with SMTP id jg9mr4969915ejc.276.1615401101627; Wed, 10 Mar 2021 10:31:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWTQg6EygPmC2GgxVCIA7ul6jWqPeNaDFR+Z37X4bE302PLYRiq0SEAQM4DxlQUSPeQ/yRpA== X-Received: by 2002:a17:907:9709:: with SMTP id jg9mr4969891ejc.276.1615401101378; Wed, 10 Mar 2021 10:31:41 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id z9sm41099edr.75.2021.03.10.10.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 10:31:41 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v6 3/7] net/eth: Better describe _eth_get_rss_ex_dst_addr's offset argument Date: Wed, 10 Mar 2021 19:31:19 +0100 Message-Id: <20210310183123.1212612-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210310183123.1212612-1-philmd@redhat.com> References: <20210310183123.1212612-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Dmitry Fleytman , Jason Wang , Paolo Bonzini , Miroslav Rezanina , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The 'offset' argument represents the offset to the ip6_ext_hdr header, rename it as 'ext_hdr_offset'. Reviewed-by: Stefano Garzarella Signed-off-by: Philippe Mathieu-Daudé --- net/eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/eth.c b/net/eth.c index b9ceb30a194..ed047b5760b 100644 --- a/net/eth.c +++ b/net/eth.c @@ -401,7 +401,7 @@ eth_is_ip6_extension_header_type(uint8_t hdr_type) static bool _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags, - size_t rthdr_offset, + size_t ext_hdr_offset, struct ip6_ext_hdr *ext_hdr, struct in6_address *dst_addr) { @@ -412,12 +412,12 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags, size_t input_size = iov_size(pkt, pkt_frags); size_t bytes_read; - if (input_size < rthdr_offset + sizeof(*ext_hdr)) { + if (input_size < ext_hdr_offset + sizeof(*ext_hdr)) { return false; } bytes_read = iov_to_buf(pkt, pkt_frags, - rthdr_offset + sizeof(*rthdr), + ext_hdr_offset + sizeof(*rthdr), dst_addr, sizeof(*dst_addr)); return bytes_read == sizeof(*dst_addr); -- 2.26.2