qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com,
	pbonzini@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
	aurelien@aurel32.net
Subject: [PATCH  v1 1/7] tests/docker: fix copying of executable in "update"
Date: Wed, 10 Mar 2021 19:23:25 +0000	[thread overview]
Message-ID: <20210310192331.29284-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210310192331.29284-1-alex.bennee@linaro.org>

We have the same symlink chasing problem when doing an "update"
operation. Fix that.

Based-on: 5e33f7fead ("tests/docker: better handle symlinked libs")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/docker.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index d28df4c140..0435a55d10 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -548,7 +548,14 @@ def run(self, args, argv):
         libs = _get_so_libs(args.executable)
         if libs:
             for l in libs:
-                tmp_tar.add(os.path.realpath(l), arcname=l)
+                so_path = os.path.dirname(l)
+                name = os.path.basename(l)
+                real_l = os.path.realpath(l)
+                try:
+                    tmp_tar.add(real_l, arcname="%s/%s" % (so_path, name))
+                except FileNotFoundError:
+                    print("Couldn't add %s/%s to archive" % (so_path, name))
+                    pass
 
         # Create a Docker buildfile
         df = StringIO()
-- 
2.20.1



  reply	other threads:[~2021-03-10 19:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 19:23 [PATCH v1 0/7] testing/next (hexagon 2, electric boogaloo) Alex Bennée
2021-03-10 19:23 ` Alex Bennée [this message]
2021-03-10 19:23 ` [PATCH v1 2/7] tests/docker: make executable an optional argument to "update" Alex Bennée
2021-03-10 19:23 ` [PATCH v1 3/7] tests/docker: allow "update" to add the current user Alex Bennée
2021-03-10 19:23 ` [PATCH v1 4/7] tests/docker: add "fetch" sub-command Alex Bennée
2021-03-10 20:13   ` Philippe Mathieu-Daudé
2021-03-10 19:23 ` [PATCH v1 5/7] docker: Add Hexagon image Alex Bennée
2021-03-10 19:23 ` [PATCH v1 6/7] tests/tcg: Use Hexagon Docker image Alex Bennée
2021-03-10 19:23 ` [PATCH v1 7/7] gitlab: add build-user-hexagon test Alex Bennée
2021-03-10 19:45 ` [PATCH v1 0/7] testing/next (hexagon 2, electric boogaloo) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310192331.29284-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).