From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH 5/4] usb: Remove "-usbdevice ccid"
Date: Thu, 11 Mar 2021 10:28:29 +0100 [thread overview]
Message-ID: <20210311092829.1479051-1-thuth@redhat.com> (raw)
In-Reply-To: <20210310173323.1422754-1-thuth@redhat.com>
"-usbdevice ccid" was not documented and -usbdevice itself was marked
as deprecated before QEMU v6.0. And searching for "-usbdevice ccid"
in the internet does not show any useful results, so likely nobody
was using the ccid device via the -usbdevice option. Remove it now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
docs/system/removed-features.rst | 6 ++++++
hw/usb/dev-smartcard-reader.c | 1 -
qemu-options.hx | 3 ---
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
index ea28904e5f..335d8a5f2f 100644
--- a/docs/system/removed-features.rst
+++ b/docs/system/removed-features.rst
@@ -45,6 +45,12 @@ This option lacked the possibility to specify an audio backend device.
Use ``-device usb-audio`` now instead (and specify a corresponding USB
host controller or ``-usb`` if necessary).
+``-usbdevice ccid`` (removed in 6.0)
+'''''''''''''''''''''''''''''''''''''
+
+This option was undocumented and not used in the field.
+Use `-device usb-ccid`` instead.
+
QEMU Machine Protocol (QMP) commands
------------------------------------
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 80109fa551..bc3d94092a 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -1492,7 +1492,6 @@ static void ccid_register_types(void)
type_register_static(&ccid_bus_info);
type_register_static(&ccid_card_type_info);
type_register_static(&ccid_info);
- usb_legacy_register(TYPE_USB_CCID_DEV, "ccid", NULL);
}
type_init(ccid_register_types)
diff --git a/qemu-options.hx b/qemu-options.hx
index fdecee758a..8f4ede1e11 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1743,9 +1743,6 @@ SRST
corresponding ``braille`` chardev automatically beside the
``usb-braille`` USB device).
- ``ccid``
- Smartcard reader device
-
``keyboard``
Standard USB keyboard. Will override the PS/2 keyboard (if present).
--
2.27.0
next prev parent reply other threads:[~2021-03-11 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 17:33 [PATCH 0/4] Clean up the -usbdevice mess Thomas Huth
2021-03-10 17:33 ` [PATCH 1/4] usb: remove support for -usbdevice parameters Thomas Huth
2021-03-10 18:19 ` Eric Blake
2021-03-10 17:33 ` [PATCH 2/4] usb: remove '-usbdevice u2f-key' Thomas Huth
2021-03-10 17:33 ` [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed) Thomas Huth
2021-03-11 8:38 ` Markus Armbruster
2021-03-11 9:14 ` Thomas Huth
2021-03-11 11:37 ` Gerd Hoffmann
2021-03-11 11:45 ` Samuel Thibault
2021-03-11 10:29 ` Paolo Bonzini
2021-03-10 17:33 ` [PATCH 4/4] usb: Document the missing -usbdevice options Thomas Huth
2021-03-11 8:41 ` [PATCH 0/4] Clean up the -usbdevice mess Gerd Hoffmann
2021-03-11 9:28 ` Thomas Huth [this message]
2021-03-17 6:04 ` [PATCH 5/4] usb: Remove "-usbdevice ccid" Thomas Huth
2021-03-17 6:40 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311092829.1479051-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).