From: Claudio Fontana <cfontana@suse.de>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Claudio Fontana <cfontana@suse.de>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: [RFC v6 15/38] target/arm: add temporary stub for arm_rebuild_hflags
Date: Thu, 11 Mar 2021 14:30:03 +0100 [thread overview]
Message-ID: <20210311133026.14052-16-cfontana@suse.de> (raw)
In-Reply-To: <20210311133026.14052-1-cfontana@suse.de>
this should go away once the configuration and hw/arm is clean
Signed-off-by: Claudio Fontana <cfontana@suse.de>
---
hw/arm/boot.c | 5 ++++-
target/arm/arm-powerctl.c | 8 +++++---
target/arm/kvm/helper-stubs.c | 6 ++++++
3 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index e56c42ac22..1fb56a846f 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -27,6 +27,7 @@
#include "qemu/option.h"
#include "exec/address-spaces.h"
#include "qemu/units.h"
+#include "sysemu/tcg.h"
/* Kernel boot protocol is specified in the kernel docs
* Documentation/arm/Booting and Documentation/arm64/booting.txt
@@ -797,7 +798,9 @@ static void do_cpu_reset(void *opaque)
info->secondary_cpu_reset_hook(cpu, info);
}
}
- arm_rebuild_hflags(env);
+ if (tcg_enabled()) {
+ arm_rebuild_hflags(env);
+ }
}
}
diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c
index b75f813b40..a00624876c 100644
--- a/target/arm/arm-powerctl.c
+++ b/target/arm/arm-powerctl.c
@@ -15,6 +15,7 @@
#include "arm-powerctl.h"
#include "qemu/log.h"
#include "qemu/main-loop.h"
+#include "sysemu/tcg.h"
#ifndef DEBUG_ARM_POWERCTL
#define DEBUG_ARM_POWERCTL 0
@@ -127,9 +128,10 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state,
target_cpu->env.regs[0] = info->context_id;
}
- /* CP15 update requires rebuilding hflags */
- arm_rebuild_hflags(&target_cpu->env);
-
+ if (tcg_enabled()) {
+ /* CP15 update requires rebuilding hflags */
+ arm_rebuild_hflags(&target_cpu->env);
+ }
/* Start the new CPU at the requested address */
cpu_set_pc(target_cpu_state, info->entry);
diff --git a/target/arm/kvm/helper-stubs.c b/target/arm/kvm/helper-stubs.c
index 8e952c91fa..a646da7acc 100644
--- a/target/arm/kvm/helper-stubs.c
+++ b/target/arm/kvm/helper-stubs.c
@@ -25,3 +25,9 @@ void write_v7m_exception(CPUARMState *env, uint32_t new_exc)
{
g_assert_not_reached();
}
+
+/* XXX this is used all over in hw/arm, needs Philippe's work to remove */
+void arm_rebuild_hflags(CPUARMState *env)
+{
+ g_assert_not_reached();
+}
--
2.26.2
next prev parent reply other threads:[~2021-03-11 13:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:29 [RFC v6 00/38] arm cleanup experiment for kvm-only build Claudio Fontana
2021-03-11 13:29 ` [RFC v6 01/38] target/arm: move translate modules to tcg/ Claudio Fontana
2021-03-11 13:29 ` [RFC v6 02/38] target/arm: move helpers " Claudio Fontana
2021-03-11 13:29 ` [RFC v6 03/38] arm: tcg: only build under CONFIG_TCG Claudio Fontana
2021-03-11 13:29 ` [RFC v6 04/38] target/arm: tcg: add sysemu and user subsirs Claudio Fontana
2021-03-11 13:29 ` [RFC v6 05/38] target/arm: only build psci for TCG Claudio Fontana
2021-03-11 13:29 ` [RFC v6 06/38] target/arm: split off cpu-sysemu.c Claudio Fontana
2021-03-11 13:29 ` [RFC v6 07/38] target/arm: move physical address translation to cpu-mmu Claudio Fontana
2021-03-11 13:29 ` [RFC v6 08/38] target/arm: cpu-mmu: fix comment style Claudio Fontana
2021-03-11 13:29 ` [RFC v6 09/38] target/arm: split cpregs from tcg/helper.c Claudio Fontana
2021-03-11 13:29 ` [RFC v6 10/38] target/arm: cpregs: fix style (mostly just comments) Claudio Fontana
2021-03-11 13:29 ` [RFC v6 11/38] target/arm: move cpu definitions to common cpu module Claudio Fontana
2021-03-11 13:30 ` [RFC v6 12/38] target/arm: only perform TCG cpu and machine inits if TCG enabled Claudio Fontana
2021-03-11 13:30 ` [RFC v6 13/38] target/arm: kvm: add stubs for some helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 14/38] target/arm: move cpsr_read, cpsr_write to cpu_common Claudio Fontana
2021-03-11 13:30 ` Claudio Fontana [this message]
2021-03-11 13:30 ` [RFC v6 16/38] target/arm: split vfp state setting from tcg helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 17/38] target/arm: move arm_mmu_idx* to cpu-mmu Claudio Fontana
2021-03-11 13:30 ` [RFC v6 18/38] target/arm: move sve_zcr_len_for_el to common_cpu Claudio Fontana
2021-03-11 13:30 ` [RFC v6 19/38] target/arm: move arm_sctlr away from tcg helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 20/38] target/arm: move arm_cpu_list to common_cpu Claudio Fontana
2021-03-11 13:30 ` [RFC v6 21/38] target/arm: move aarch64_sync_32_to_64 (and vv) to cpu code Claudio Fontana
2021-03-11 13:30 ` [RFC v6 22/38] target/arm: split a15 cpu model and 32bit class functions to cpu32.c Claudio Fontana
2021-03-11 13:30 ` [RFC v6 23/38] target/arm: move sve_exception_el out of TCG helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 24/38] target/arm: refactor exception and cpu code Claudio Fontana
2021-03-11 13:30 ` [RFC v6 25/38] target/arm: cpu: fix style Claudio Fontana
2021-03-11 18:30 ` Philippe Mathieu-Daudé
2021-03-11 13:30 ` [RFC v6 26/38] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled() Claudio Fontana
2021-03-11 13:30 ` [RFC v6 27/38] target/arm: remove kvm include file for PSCI and arm-powerctl Claudio Fontana
2021-03-11 13:30 ` [RFC v6 28/38] target/arm: move kvm-const.h, kvm.c, kvm64.c, kvm_arm.h to kvm/ Claudio Fontana
2021-03-11 13:30 ` [RFC v6 29/38] target/arm: cleanup cpu includes Claudio Fontana
2021-03-11 13:30 ` [RFC v6 30/38] target/arm: remove broad "else" statements when checking accels Claudio Fontana
2021-03-11 13:30 ` [RFC v6 31/38] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM Claudio Fontana
2021-03-11 13:30 ` [RFC v6 32/38] tests: restrict TCG-only arm-cpu-features tests to TCG builds Claudio Fontana
2021-03-11 13:30 ` [RFC v6 33/38] tests: do not run test-hmp on all machines for ARM KVM-only Claudio Fontana
2021-03-11 13:30 ` [RFC v6 34/38] tests: device-introspect-test: cope with ARM TCG-only devices Claudio Fontana
2021-03-11 13:30 ` [RFC v6 35/38] tests: do not run qom-test on all machines for ARM KVM-only Claudio Fontana
2021-03-11 13:30 ` [RFC v6 36/38] Revert "target/arm: Restrict v8M IDAU to TCG" Claudio Fontana
2021-03-11 13:30 ` [RFC v6 37/38] kvm: create kvm cpu accel class Claudio Fontana
2021-03-11 13:30 ` [RFC v6 38/38] target/arm: move kvm cpu properties setting to kvm-cpu Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311133026.14052-16-cfontana@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).