qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Fontana <cfontana@suse.de>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, "Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [RFC v6 33/38] tests: do not run test-hmp on all machines for ARM KVM-only
Date: Thu, 11 Mar 2021 14:30:21 +0100	[thread overview]
Message-ID: <20210311133026.14052-34-cfontana@suse.de> (raw)
In-Reply-To: <20210311133026.14052-1-cfontana@suse.de>

on ARM we currently list and build all machines, even when
building KVM-only, without TCG.

Until we fix this (and we only list and build machines that are
compatible with KVM), only test specifically using the "virt"
machine in this case.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/qtest/test-hmp.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
index 94a8023173..d8b3357280 100644
--- a/tests/qtest/test-hmp.c
+++ b/tests/qtest/test-hmp.c
@@ -157,8 +157,28 @@ int main(int argc, char **argv)
 
     g_test_init(&argc, &argv, NULL);
 
+    /*
+     * XXX currently we build also boards for ARM that are incompatible with KVM.
+     * We therefore need to check this explicitly, and only test virt for kvm-only
+     * arm builds.
+     * After we do the work of Kconfig etc to ensure that only KVM-compatible boards
+     * are built for the kvm-only build, we could remove this.
+     */
+#ifndef CONFIG_TCG
+    {
+        const char *arch = qtest_get_arch();
+
+        if (strcmp(arch, "arm") == 0 || strcmp(arch, "aarch64") == 0) {
+            add_machine_test_case("virt");
+            goto add_machine_test_done;
+        }
+    }
+#endif /* !CONFIG_TCG */
+
     qtest_cb_for_every_machine(add_machine_test_case, g_test_quick());
+    goto add_machine_test_done;
 
+ add_machine_test_done:
     /* as none machine has no memory by default, add a test case with memory */
     qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine);
 
-- 
2.26.2



  parent reply	other threads:[~2021-03-11 14:07 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 13:29 [RFC v6 00/38] arm cleanup experiment for kvm-only build Claudio Fontana
2021-03-11 13:29 ` [RFC v6 01/38] target/arm: move translate modules to tcg/ Claudio Fontana
2021-03-11 13:29 ` [RFC v6 02/38] target/arm: move helpers " Claudio Fontana
2021-03-11 13:29 ` [RFC v6 03/38] arm: tcg: only build under CONFIG_TCG Claudio Fontana
2021-03-11 13:29 ` [RFC v6 04/38] target/arm: tcg: add sysemu and user subsirs Claudio Fontana
2021-03-11 13:29 ` [RFC v6 05/38] target/arm: only build psci for TCG Claudio Fontana
2021-03-11 13:29 ` [RFC v6 06/38] target/arm: split off cpu-sysemu.c Claudio Fontana
2021-03-11 13:29 ` [RFC v6 07/38] target/arm: move physical address translation to cpu-mmu Claudio Fontana
2021-03-11 13:29 ` [RFC v6 08/38] target/arm: cpu-mmu: fix comment style Claudio Fontana
2021-03-11 13:29 ` [RFC v6 09/38] target/arm: split cpregs from tcg/helper.c Claudio Fontana
2021-03-11 13:29 ` [RFC v6 10/38] target/arm: cpregs: fix style (mostly just comments) Claudio Fontana
2021-03-11 13:29 ` [RFC v6 11/38] target/arm: move cpu definitions to common cpu module Claudio Fontana
2021-03-11 13:30 ` [RFC v6 12/38] target/arm: only perform TCG cpu and machine inits if TCG enabled Claudio Fontana
2021-03-11 13:30 ` [RFC v6 13/38] target/arm: kvm: add stubs for some helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 14/38] target/arm: move cpsr_read, cpsr_write to cpu_common Claudio Fontana
2021-03-11 13:30 ` [RFC v6 15/38] target/arm: add temporary stub for arm_rebuild_hflags Claudio Fontana
2021-03-11 13:30 ` [RFC v6 16/38] target/arm: split vfp state setting from tcg helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 17/38] target/arm: move arm_mmu_idx* to cpu-mmu Claudio Fontana
2021-03-11 13:30 ` [RFC v6 18/38] target/arm: move sve_zcr_len_for_el to common_cpu Claudio Fontana
2021-03-11 13:30 ` [RFC v6 19/38] target/arm: move arm_sctlr away from tcg helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 20/38] target/arm: move arm_cpu_list to common_cpu Claudio Fontana
2021-03-11 13:30 ` [RFC v6 21/38] target/arm: move aarch64_sync_32_to_64 (and vv) to cpu code Claudio Fontana
2021-03-11 13:30 ` [RFC v6 22/38] target/arm: split a15 cpu model and 32bit class functions to cpu32.c Claudio Fontana
2021-03-11 13:30 ` [RFC v6 23/38] target/arm: move sve_exception_el out of TCG helpers Claudio Fontana
2021-03-11 13:30 ` [RFC v6 24/38] target/arm: refactor exception and cpu code Claudio Fontana
2021-03-11 13:30 ` [RFC v6 25/38] target/arm: cpu: fix style Claudio Fontana
2021-03-11 18:30   ` Philippe Mathieu-Daudé
2021-03-11 13:30 ` [RFC v6 26/38] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled() Claudio Fontana
2021-03-11 13:30 ` [RFC v6 27/38] target/arm: remove kvm include file for PSCI and arm-powerctl Claudio Fontana
2021-03-11 13:30 ` [RFC v6 28/38] target/arm: move kvm-const.h, kvm.c, kvm64.c, kvm_arm.h to kvm/ Claudio Fontana
2021-03-11 13:30 ` [RFC v6 29/38] target/arm: cleanup cpu includes Claudio Fontana
2021-03-11 13:30 ` [RFC v6 30/38] target/arm: remove broad "else" statements when checking accels Claudio Fontana
2021-03-11 13:30 ` [RFC v6 31/38] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM Claudio Fontana
2021-03-11 13:30 ` [RFC v6 32/38] tests: restrict TCG-only arm-cpu-features tests to TCG builds Claudio Fontana
2021-03-11 13:30 ` Claudio Fontana [this message]
2021-03-11 13:30 ` [RFC v6 34/38] tests: device-introspect-test: cope with ARM TCG-only devices Claudio Fontana
2021-03-11 13:30 ` [RFC v6 35/38] tests: do not run qom-test on all machines for ARM KVM-only Claudio Fontana
2021-03-11 13:30 ` [RFC v6 36/38] Revert "target/arm: Restrict v8M IDAU to TCG" Claudio Fontana
2021-03-11 13:30 ` [RFC v6 37/38] kvm: create kvm cpu accel class Claudio Fontana
2021-03-11 13:30 ` [RFC v6 38/38] target/arm: move kvm cpu properties setting to kvm-cpu Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311133026.14052-34-cfontana@suse.de \
    --to=cfontana@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).