* [PATCH 2/3] block: allow filters to be reopened without .bdrv_reopen_prepare
2021-03-11 15:15 [PATCH RFC 0/3] block: drop inherits_from Vladimir Sementsov-Ogievskiy
2021-03-11 15:15 ` [PATCH 1/3] block/commit: keep reference on commit_top_bs Vladimir Sementsov-Ogievskiy
@ 2021-03-11 15:15 ` Vladimir Sementsov-Ogievskiy
2021-03-11 15:15 ` [PATCH 3/3] block: drop inherits_from logic Vladimir Sementsov-Ogievskiy
2021-03-11 17:09 ` [PATCH RFC 0/3] block: drop inherits_from Kevin Wolf
3 siblings, 0 replies; 6+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-03-11 15:15 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, vsementsov, jsnow, mreitz, kwolf, den
We are going to drop inherits_from logic, so every child will be
recursively reopened including filters. Let's assume that by default
filters do nothing on reopen prepare.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block.c | 23 +++++++++++++----------
tests/qemu-iotests/245 | 5 ++---
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/block.c b/block.c
index 2daff6d29a..815396f460 100644
--- a/block.c
+++ b/block.c
@@ -4189,7 +4189,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue,
goto error;
}
- if (drv->bdrv_reopen_prepare) {
+ if (drv->bdrv_reopen_prepare || drv->is_filter) {
/*
* If a driver-specific option is missing, it means that we
* should reset it to its default value.
@@ -4201,16 +4201,19 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue,
goto error;
}
- ret = drv->bdrv_reopen_prepare(reopen_state, queue, &local_err);
- if (ret) {
- if (local_err != NULL) {
- error_propagate(errp, local_err);
- } else {
- bdrv_refresh_filename(reopen_state->bs);
- error_setg(errp, "failed while preparing to reopen image '%s'",
- reopen_state->bs->filename);
+ if (drv->bdrv_reopen_prepare) {
+ ret = drv->bdrv_reopen_prepare(reopen_state, queue, &local_err);
+ if (ret) {
+ if (local_err != NULL) {
+ error_propagate(errp, local_err);
+ } else {
+ bdrv_refresh_filename(reopen_state->bs);
+ error_setg(errp,
+ "failed while preparing to reopen image '%s'",
+ reopen_state->bs->filename);
+ }
+ goto error;
}
- goto error;
}
} else {
/* It is currently mandatory to have a bdrv_reopen_prepare()
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
index 11104b9208..a7c70213dd 100755
--- a/tests/qemu-iotests/245
+++ b/tests/qemu-iotests/245
@@ -524,9 +524,8 @@ class TestBlockdevReopen(iotests.QMPTestCase):
result = self.vm.qmp('blockdev-add', conv_keys = False, **bvopts)
self.assert_qmp(result, 'return', {})
- # blkverify doesn't currently allow reopening. TODO: implement this
- self.reopen(bvopts, {}, "Block format 'blkverify' used by node 'bv'" +
- " does not support reopening files")
+ # blkverify allows reopening
+ self.reopen(bvopts, {})
# Illegal: hd0 is a child of the blkverify node
self.reopen(opts[0], {'backing': 'bv'},
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] block: drop inherits_from logic
2021-03-11 15:15 [PATCH RFC 0/3] block: drop inherits_from Vladimir Sementsov-Ogievskiy
2021-03-11 15:15 ` [PATCH 1/3] block/commit: keep reference on commit_top_bs Vladimir Sementsov-Ogievskiy
2021-03-11 15:15 ` [PATCH 2/3] block: allow filters to be reopened without .bdrv_reopen_prepare Vladimir Sementsov-Ogievskiy
@ 2021-03-11 15:15 ` Vladimir Sementsov-Ogievskiy
2021-03-11 17:09 ` [PATCH RFC 0/3] block: drop inherits_from Kevin Wolf
3 siblings, 0 replies; 6+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-03-11 15:15 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, vsementsov, jsnow, mreitz, kwolf, den
inherits_from is used only to restrict recursively adding of block
children to reopen queue. Still, we have public block graph and we are
going to "blockdev" era, when user controls every nobe of block graph.
So, what's wrong in just reopening every child? Moreover, is it correct
to silently skip children hidden by filters from reopen process? We
have BdrvChildClass::inherit_options() to specify how child inherits
options. Why some dynamically created children should not inherit what
they want?
Dropping inherits_from simplifies things a bit, clearing the way for
updating fixing and refactoring of block graph permission update.
Also, inherits_from has some problems:
1. bdrv_unset_inherits_from() is called only from bdrv_unref_child(),
when it probably should be called from bdrv_replace_child_noperm()
to cover more cases.
2. bdrv_unset_inherits_from() tries to check that root has two children
with same child->bs, but it doesn't check that there may be several
long paths from root to bs.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
include/block/block_int.h | 4 ---
block.c | 72 --------------------------------------
tests/qemu-iotests/245 | 31 ++++++++++------
tests/qemu-iotests/245.out | 8 +++--
4 files changed, 27 insertions(+), 88 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 88e4111939..ae8db04a0a 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -935,10 +935,6 @@ struct BlockDriverState {
/* operation blockers */
QLIST_HEAD(, BdrvOpBlocker) op_blockers[BLOCK_OP_TYPE_MAX];
- /* The node that this node inherited default options from (and a reopen on
- * which can affect this node by changing these defaults). This is always a
- * parent node of this node. */
- BlockDriverState *inherits_from;
QLIST_HEAD(, BdrvChild) children;
QLIST_HEAD(, BdrvChild) parents;
diff --git a/block.c b/block.c
index 815396f460..af4f6095ca 100644
--- a/block.c
+++ b/block.c
@@ -2769,34 +2769,6 @@ void bdrv_root_unref_child(BdrvChild *child)
bdrv_unref(child_bs);
}
-/**
- * Clear all inherits_from pointers from children and grandchildren of
- * @root that point to @root, where necessary.
- */
-static void bdrv_unset_inherits_from(BlockDriverState *root, BdrvChild *child)
-{
- BdrvChild *c;
-
- if (child->bs->inherits_from == root) {
- /*
- * Remove inherits_from only when the last reference between root and
- * child->bs goes away.
- */
- QLIST_FOREACH(c, &root->children, next) {
- if (c != child && c->bs == child->bs) {
- break;
- }
- }
- if (c == NULL) {
- child->bs->inherits_from = NULL;
- }
- }
-
- QLIST_FOREACH(c, &child->bs->children, next) {
- bdrv_unset_inherits_from(root, c);
- }
-}
-
/* Callers must ensure that child->frozen is false. */
void bdrv_unref_child(BlockDriverState *parent, BdrvChild *child)
{
@@ -2804,7 +2776,6 @@ void bdrv_unref_child(BlockDriverState *parent, BdrvChild *child)
return;
}
- bdrv_unset_inherits_from(parent, child);
bdrv_root_unref_child(child);
}
@@ -2819,18 +2790,6 @@ static void bdrv_parent_cb_change_media(BlockDriverState *bs, bool load)
}
}
-/* Return true if you can reach parent going through child->inherits_from
- * recursively. If parent or child are NULL, return false */
-static bool bdrv_inherits_from_recursive(BlockDriverState *child,
- BlockDriverState *parent)
-{
- while (child && child != parent) {
- child = child->inherits_from;
- }
-
- return child != NULL;
-}
-
/*
* Return the BdrvChildRole for @bs's backing child. bs->backing is
* mostly used for COW backing children (role = COW), but also for
@@ -2853,8 +2812,6 @@ int bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
Error **errp)
{
int ret = 0;
- bool update_inherits_from = bdrv_chain_contains(bs, backing_hd) &&
- bdrv_inherits_from_recursive(backing_hd, bs);
if (bdrv_is_backing_chain_frozen(bs, child_bs(bs->backing), errp)) {
return -EPERM;
@@ -2881,13 +2838,6 @@ int bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
goto out;
}
- /* If backing_hd was already part of bs's backing chain, and
- * inherits_from pointed recursively to bs then let's update it to
- * point directly to bs (else it will become NULL). */
- if (update_inherits_from) {
- backing_hd->inherits_from = bs;
- }
-
out:
bdrv_refresh_limits(bs, NULL);
@@ -3283,7 +3233,6 @@ static BlockDriverState *bdrv_open_inherit(const char *filename,
parent_is_format = true;
}
- bs->inherits_from = parent;
child_class->inherit_options(child_role, parent_is_format,
&flags, options,
parent->open_flags, parent->options);
@@ -3717,13 +3666,6 @@ static BlockReopenQueue *bdrv_reopen_queue_child(BlockReopenQueue *bs_queue,
QDict *new_child_options = NULL;
bool child_keep_old = keep_old_opts;
- /* reopen can only change the options of block devices that were
- * implicitly created and inherited options. For other (referenced)
- * block devices, a syntax like "backing.foo" results in an error. */
- if (child->bs->inherits_from != bs) {
- continue;
- }
-
/* Check if the options contain a child reference */
if (qdict_haskey(options, child->name)) {
const char *childref = qdict_get_try_str(options, child->name);
@@ -4933,8 +4875,6 @@ void bdrv_unfreeze_backing_chain(BlockDriverState *bs, BlockDriverState *base)
int bdrv_drop_intermediate(BlockDriverState *top, BlockDriverState *base,
const char *backing_file_str)
{
- BlockDriverState *explicit_top = top;
- bool update_inherits_from;
BdrvChild *c;
Error *local_err = NULL;
int ret = -EIO;
@@ -4953,14 +4893,6 @@ int bdrv_drop_intermediate(BlockDriverState *top, BlockDriverState *base,
goto exit;
}
- /* If 'base' recursively inherits from 'top' then we should set
- * base->inherits_from to top->inherits_from after 'top' and all
- * other intermediate nodes have been dropped.
- * If 'top' is an implicit node (e.g. "commit_top") we should skip
- * it because no one inherits from it. We use explicit_top for that. */
- explicit_top = bdrv_skip_implicit_filters(explicit_top);
- update_inherits_from = bdrv_inherits_from_recursive(base, explicit_top);
-
/* success - we can delete the intermediate states, and link top->base */
/* TODO Check graph modification op blockers (BLK_PERM_GRAPH_MOD) once
* we've figured out how they should work. */
@@ -5001,10 +4933,6 @@ int bdrv_drop_intermediate(BlockDriverState *top, BlockDriverState *base,
}
}
- if (update_inherits_from) {
- base->inherits_from = explicit_top->inherits_from;
- }
-
ret = 0;
exit:
bdrv_subtree_drained_end(top);
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
index a7c70213dd..9fcb1b144e 100755
--- a/tests/qemu-iotests/245
+++ b/tests/qemu-iotests/245
@@ -307,8 +307,9 @@ class TestBlockdevReopen(iotests.QMPTestCase):
self.reopen(hd_opts(0), {'read-only': True})
self.check_node_graph(original_graph)
- # The backing file (hd0) is now a reference, we cannot change backing.* anymore
- self.reopen(opts, {}, "Cannot change the option 'backing.driver'")
+ # The backing file (hd0) is now a reference, buf we can change
+ # backing.* anyway
+ self.reopen(opts, {})
# We can't remove 'hd0' while it's a backing image of 'hd1'
result = self.vm.qmp('blockdev-del', conv_keys = True, node_name = 'hd0')
@@ -899,7 +900,7 @@ class TestBlockdevReopen(iotests.QMPTestCase):
# We can't reopen with the original options because there is a filter
# inserted by stream job above hd1.
self.reopen(opts, {},
- "Cannot change the option 'backing.backing.file.node-name'")
+ "Option 'bottom' cannot be reset to its default value")
# We can't reopen hd1 to read-only, as block-stream requires it to be
# read-write
@@ -949,7 +950,7 @@ class TestBlockdevReopen(iotests.QMPTestCase):
self.wait_until_completed(drive = 'commit0')
# Reopen the chain during a block-commit job (from hd1 to hd2)
- def test_block_commit_2(self):
+ def do_test_block_commit_2(self, detach_hd1):
# hd2 <- hd1 <- hd0
opts = hd_opts(0)
opts['backing'] = hd_opts(1)
@@ -959,23 +960,33 @@ class TestBlockdevReopen(iotests.QMPTestCase):
result = self.vm.qmp('block-commit', conv_keys = True, job_id = 'commit0',
device = 'hd0', top_node = 'hd1',
- auto_finalize = False)
+ auto_finalize = False, filter_node_name = 'fl')
self.assert_qmp(result, 'return', {})
# We can't remove hd2 while the commit job is ongoing
opts['backing']['backing'] = None
- self.reopen(opts, {}, "Cannot change the option 'backing.driver'")
+ self.reopen(opts, {}, "Cannot change 'backing' link from 'fl' to 'hd1'")
- # We can't remove hd1 while the commit job is ongoing
- opts['backing'] = None
- self.reopen(opts, {}, "Cannot change backing link if 'hd0' has an implicit backing file")
+ if (detach_hd1):
+ # But nothing wrong in detaching hd1 together with the commit job
+ opts['backing'] = None
+ self.reopen(opts, {})
# hd2 <- hd0
self.vm.run_job('commit0', auto_finalize = False, auto_dismiss = True)
self.assert_qmp(self.get_node('hd0'), 'ro', False)
self.assertEqual(self.get_node('hd1'), None)
- self.assert_qmp(self.get_node('hd2'), 'ro', True)
+ if detach_hd1:
+ self.assertEqual(self.get_node('hd2'), None)
+ else:
+ self.assert_qmp(self.get_node('hd2'), 'ro', True)
+
+ def test_block_commit_2(self):
+ self.do_test_block_commit_2(False)
+
+ def test_block_commit_3(self):
+ self.do_test_block_commit_2(True)
def run_test_iothreads(self, iothread_a, iothread_b, errmsg = None):
opts = hd_opts(0)
diff --git a/tests/qemu-iotests/245.out b/tests/qemu-iotests/245.out
index 4b33dcaf5c..c1fda88f1a 100644
--- a/tests/qemu-iotests/245.out
+++ b/tests/qemu-iotests/245.out
@@ -2,6 +2,10 @@
{"return": {}}
{"data": {"id": "commit0", "type": "commit"}, "event": "BLOCK_JOB_PENDING", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
{"data": {"device": "commit0", "len": 3145728, "offset": 3145728, "speed": 0, "type": "commit"}, "event": "BLOCK_JOB_COMPLETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
+{"execute": "job-finalize", "arguments": {"id": "commit0"}}
+{"return": {}}
+{"data": {"id": "commit0", "type": "commit"}, "event": "BLOCK_JOB_PENDING", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
+{"data": {"device": "commit0", "len": 3145728, "offset": 3145728, "speed": 0, "type": "commit"}, "event": "BLOCK_JOB_COMPLETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
{"execute": "job-finalize", "arguments": {"id": "stream0"}}
{"return": {}}
{"data": {"id": "stream0", "type": "stream"}, "event": "BLOCK_JOB_PENDING", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
@@ -10,8 +14,8 @@
{"return": {}}
{"data": {"id": "stream0", "type": "stream"}, "event": "BLOCK_JOB_PENDING", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
{"data": {"device": "stream0", "len": 3145728, "offset": 3145728, "speed": 0, "type": "stream"}, "event": "BLOCK_JOB_COMPLETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
-.....................
+......................
----------------------------------------------------------------------
-Ran 21 tests
+Ran 22 tests
OK
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread