From: Stefano Garzarella <sgarzare@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] qemu-timer: allow freeing a NULL timer
Date: Thu, 11 Mar 2021 18:06:21 +0100 [thread overview]
Message-ID: <20210311170621.ahcelcm6gdueri42@steredhat> (raw)
In-Reply-To: <20210310154526.463850-1-pbonzini@redhat.com>
On Wed, Mar 10, 2021 at 10:45:26AM -0500, Paolo Bonzini wrote:
>Since 5f8e93c3e2 ("util/qemu-timer: Make timer_free() imply timer_del()", 2021-01-08)
>it is not possible anymore to pass a NULL pointer to timer_free(). Previously
>it would do nothing as it would simply pass NULL down to g_free().
>
>Rectify this, which also fixes "-chardev braille" when there is no device.
>
>Reported-by: Markus Armbruster <armbru@redhat.com>
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>---
> include/qemu/timer.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
prev parent reply other threads:[~2021-03-11 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 15:45 [PATCH] qemu-timer: allow freeing a NULL timer Paolo Bonzini
2021-03-10 15:53 ` Philippe Mathieu-Daudé
2021-03-11 17:06 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311170621.ahcelcm6gdueri42@steredhat \
--to=sgarzare@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).