qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH 3/4] ui: use client width/height in WMVi message
Date: Thu, 11 Mar 2021 18:29:56 +0000	[thread overview]
Message-ID: <20210311182957.486939-4-berrange@redhat.com> (raw)
In-Reply-To: <20210311182957.486939-1-berrange@redhat.com>

The WMVi message is supposed to provide the same width/height
information as the regular desktop resize and extended desktop
resize messages. There can be times where the client width and
height are different from the pixman surface dimensions.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 ui/vnc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index 7291429c04..8c9890b3cd 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2319,8 +2319,8 @@ static void vnc_colordepth(VncState *vs)
         vnc_write_u8(vs, 0);
         vnc_write_u16(vs, 1); /* number of rects */
         vnc_framebuffer_update(vs, 0, 0,
-                               pixman_image_get_width(vs->vd->server),
-                               pixman_image_get_height(vs->vd->server),
+                               vs->client_width,
+                               vs->client_height,
                                VNC_ENCODING_WMVi);
         pixel_format_message(vs);
         vnc_unlock_output(vs);
-- 
2.29.2



  parent reply	other threads:[~2021-03-11 18:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 18:29 [PATCH 0/4] ui: improve precision of VNC desktop resizing Daniel P. Berrangé
2021-03-11 18:29 ` [PATCH 1/4] ui: add more trace points for VNC client/server messages Daniel P. Berrangé
2021-03-11 21:12   ` Marc-André Lureau
2021-03-11 18:29 ` [PATCH 2/4] ui: avoid sending framebuffer updates outside client desktop bounds Daniel P. Berrangé
2021-03-11 21:15   ` Marc-André Lureau
2021-03-11 18:29 ` Daniel P. Berrangé [this message]
2021-03-11 21:19   ` [PATCH 3/4] ui: use client width/height in WMVi message Marc-André Lureau
2021-03-11 18:29 ` [PATCH 4/4] ui: honour the actual guest display dimensions without rounding Daniel P. Berrangé
2021-03-12  6:48   ` Marc-André Lureau
2021-03-12 10:36 ` [PATCH 0/4] ui: improve precision of VNC desktop resizing Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311182957.486939-4-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).