qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Claudio Fontana <cfontana@suse.de>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Andrew Jones" <drjones@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: [PATCH 4/6] qtest/arm-cpu-features: Check KVM availability at runtime
Date: Fri, 12 Mar 2021 00:12:00 +0100	[thread overview]
Message-ID: <20210311231202.1536040-5-philmd@redhat.com> (raw)
In-Reply-To: <20210311231202.1536040-1-philmd@redhat.com>

sve_tests_sve_off_kvm() and test_query_cpu_model_expansion_kvm()
are KVM specific tests. Skip them if KVM is not built-in.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/qtest/arm-cpu-features.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
index 8252b85bb85..2b70104515d 100644
--- a/tests/qtest/arm-cpu-features.c
+++ b/tests/qtest/arm-cpu-features.c
@@ -21,7 +21,7 @@
 #define SVE_MAX_VQ 16
 
 #define MACHINE     "-machine virt,gic-version=max -accel tcg "
-#define MACHINE_KVM "-machine virt,gic-version=max -accel kvm -accel tcg "
+#define MACHINE_KVM "-machine virt,gic-version=max -accel kvm "
 #define QUERY_HEAD  "{ 'execute': 'query-cpu-model-expansion', " \
                     "  'arguments': { 'type': 'full', "
 #define QUERY_TAIL  "}}"
@@ -413,6 +413,10 @@ static void sve_tests_sve_off_kvm(const void *data)
     QTestState *qts;
 
     qts = qtest_init(MACHINE_KVM "-cpu max,sve=off");
+    if (!qtest_probe_accel(qts, "kvm")) {
+        g_test_skip("KVM not available, skipping test");
+        goto done;
+    }
 
     /*
      * We don't know if this host supports SVE so we don't
@@ -424,6 +428,7 @@ static void sve_tests_sve_off_kvm(const void *data)
     assert_sve_vls(qts, "max", 0, NULL);
     assert_sve_vls(qts, "max", 0, "{ 'sve128': false }");
 
+done:
     qtest_quit(qts);
 }
 
@@ -492,6 +497,10 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
     QTestState *qts;
 
     qts = qtest_init(MACHINE_KVM "-cpu max");
+    if (!qtest_probe_accel(qts, "kvm")) {
+        g_test_skip("KVM not available, skipping test");
+        goto done;
+    }
 
     /*
      * These tests target the 'host' CPU type, so KVM must be enabled.
@@ -609,6 +618,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
         assert_has_not_feature(qts, "host", "kvm-steal-time");
     }
 
+done:
     qtest_quit(qts);
 }
 
-- 
2.26.2



  parent reply	other threads:[~2021-03-11 23:17 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 23:11 [PATCH 0/6] qtests: Check accelerator available at runtime via QMP 'query-accels' Philippe Mathieu-Daudé
2021-03-11 23:11 ` [PATCH 1/6] accel: Introduce 'query-accels' QMP command Philippe Mathieu-Daudé
2021-03-12  7:42   ` Marc-André Lureau
2021-03-12  8:11     ` Thomas Huth
2021-03-12  8:48       ` Andrew Jones
2021-03-12  8:52         ` Claudio Fontana
2021-03-12  9:09           ` Andrew Jones
2021-03-12  9:01         ` Paolo Bonzini
2021-03-12  9:17           ` Andrew Jones
2021-03-12  9:28             ` Paolo Bonzini
2021-03-12  8:46     ` Claudio Fontana
2021-03-12  9:04       ` Paolo Bonzini
2021-03-15 17:53   ` Eric Blake
2021-03-16  6:51     ` Markus Armbruster
2021-03-16  8:21       ` Paolo Bonzini
2021-03-16  9:02       ` Philippe Mathieu-Daudé
2021-03-16 10:26         ` Philippe Mathieu-Daudé
2021-03-16 10:39           ` Markus Armbruster
2021-03-16 10:55           ` Philippe Mathieu-Daudé
2021-03-16 12:41             ` Markus Armbruster
2021-03-16 12:48               ` Thomas Huth
2021-03-16 15:20                 ` Philippe Mathieu-Daudé
2021-03-11 23:11 ` [PATCH 2/6] tests/qtest: Add qtest_probe_accel() method Philippe Mathieu-Daudé
2021-03-12  8:16   ` Thomas Huth
2021-03-12  8:58     ` Andrew Jones
2021-03-11 23:11 ` [PATCH 3/6] qtest/bios-tables-test: Make test build-independent from accelerator Philippe Mathieu-Daudé
2021-03-11 23:12 ` Philippe Mathieu-Daudé [this message]
2021-03-12  9:05   ` [PATCH 4/6] qtest/arm-cpu-features: Check KVM availability at runtime Paolo Bonzini
2021-03-12  9:32     ` Philippe Mathieu-Daudé
2021-03-12  9:50       ` Paolo Bonzini
2021-03-11 23:12 ` [PATCH 5/6] qtest/arm-cpu-features: Check TCG " Philippe Mathieu-Daudé
2021-03-12  9:05   ` Paolo Bonzini
2021-03-11 23:12 ` [PATCH 6/6] tests/qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore Philippe Mathieu-Daudé
2021-03-12  9:06   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311231202.1536040-5-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cfontana@suse.de \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).