From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: virtio-fs@redhat.com, Miklos Szeredi <mszeredi@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Greg Kurz <groug@kaod.org>
Subject: [PATCH 2/3] virtiofsd: Convert some functions to return bool
Date: Fri, 12 Mar 2021 15:10:02 +0100 [thread overview]
Message-ID: <20210312141003.819108-3-groug@kaod.org> (raw)
In-Reply-To: <20210312141003.819108-1-groug@kaod.org>
Both currently only return 0 or 1.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
tools/virtiofsd/passthrough_ll.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 27a6c636dcaf..f63016d35626 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -221,17 +221,17 @@ static struct lo_inode *lo_find(struct lo_data *lo, struct stat *st,
static int xattr_map_client(const struct lo_data *lo, const char *client_name,
char **out_name);
-static int is_dot_or_dotdot(const char *name)
+static bool is_dot_or_dotdot(const char *name)
{
return name[0] == '.' &&
(name[1] == '\0' || (name[1] == '.' && name[2] == '\0'));
}
/* Is `path` a single path component that is not "." or ".."? */
-static int is_safe_path_component(const char *path)
+static bool is_safe_path_component(const char *path)
{
if (strchr(path, '/')) {
- return 0;
+ return false;
}
return !is_dot_or_dotdot(path);
--
2.26.2
next prev parent reply other threads:[~2021-03-12 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 14:10 [PATCH 0/3] virtiofsd: Deal with empty filenames Greg Kurz
2021-03-12 14:10 ` [PATCH 1/3] virtiofsd: Don't allow empty paths in lookup_name() Greg Kurz
2021-03-12 15:13 ` [Virtio-fs] " Connor Kuehl
2021-03-12 15:49 ` Greg Kurz
2021-03-14 23:38 ` Vivek Goyal
2021-03-12 14:10 ` Greg Kurz [this message]
2021-03-12 15:13 ` [Virtio-fs] [PATCH 2/3] virtiofsd: Convert some functions to return bool Connor Kuehl
2021-03-14 23:36 ` Vivek Goyal
2021-03-12 14:10 ` [PATCH 3/3] virtiofsd: Don't allow empty filenames Greg Kurz
2021-03-12 15:13 ` [Virtio-fs] " Connor Kuehl
2021-03-14 23:36 ` Vivek Goyal
2021-03-15 10:06 ` Greg Kurz
2021-03-15 15:18 ` Dr. David Alan Gilbert
2021-03-15 17:37 ` Greg Kurz
2021-03-15 17:55 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312141003.819108-3-groug@kaod.org \
--to=groug@kaod.org \
--cc=dgilbert@redhat.com \
--cc=mszeredi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).