From: Claudio Fontana <cfontana@suse.de>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Roman Bolshakov" <r.bolshakov@yadro.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [RFC v7 25/42] target/arm: cpu: fix style
Date: Fri, 12 Mar 2021 18:22:26 +0100 [thread overview]
Message-ID: <20210312172243.25334-26-cfontana@suse.de> (raw)
In-Reply-To: <20210312172243.25334-1-cfontana@suse.de>
Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/arm/cpu-sysemu.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/target/arm/cpu-sysemu.c b/target/arm/cpu-sysemu.c
index 126263dbf4..eb928832a9 100644
--- a/target/arm/cpu-sysemu.c
+++ b/target/arm/cpu-sysemu.c
@@ -372,7 +372,8 @@ int sve_exception_el(CPUARMState *env, int el)
if (el <= 1 && (hcr_el2 & (HCR_E2H | HCR_TGE)) != (HCR_E2H | HCR_TGE)) {
bool disabled = false;
- /* The CPACR.ZEN controls traps to EL1:
+ /*
+ * The CPACR.ZEN controls traps to EL1:
* 0, 2 : trap EL0 and EL1 accesses
* 1 : trap only EL0 accesses
* 3 : trap no accesses
@@ -398,7 +399,8 @@ int sve_exception_el(CPUARMState *env, int el)
}
}
- /* CPTR_EL2. Since TZ and TFP are positive,
+ /*
+ * CPTR_EL2. Since TZ and TFP are positive,
* they will be zero when EL2 is not present.
*/
if (el <= 2 && arm_is_el2_enabled(env)) {
@@ -625,10 +627,11 @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
new_mode = ARM_CPU_MODE_UND;
addr = 0x04;
mask = CPSR_I;
- if (env->thumb)
+ if (env->thumb) {
offset = 2;
- else
+ } else {
offset = 4;
+ }
break;
case EXCP_SWI:
new_mode = ARM_CPU_MODE_SVC;
@@ -714,7 +717,8 @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
/* High vectors. When enabled, base address cannot be remapped. */
addr += 0xffff0000;
} else {
- /* ARM v7 architectures provide a vector base address register to remap
+ /*
+ * ARM v7 architectures provide a vector base address register to remap
* the interrupt vector table.
* This register is only followed in non-monitor mode, and is banked.
* Note: only bits 31:5 are valid.
@@ -1013,7 +1017,8 @@ void arm_log_exception(int idx)
}
}
-/* Handle a CPU exception for A and R profile CPUs.
+/*
+ * Handle a CPU exception for A and R profile CPUs.
* Do any appropriate logging, handle PSCI calls, and then hand off
* to the AArch64-entry or AArch32-entry function depending on the
* target exception level's register width.
--
2.26.2
next prev parent reply other threads:[~2021-03-12 17:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 17:22 [RFC v7 00/42] arm cleanup experiment for kvm-only build Claudio Fontana
2021-03-12 17:22 ` [RFC v7 01/42] target/arm: move translate modules to tcg/ Claudio Fontana
2021-03-12 17:22 ` [RFC v7 02/42] target/arm: move helpers " Claudio Fontana
2021-03-12 17:22 ` [RFC v7 03/42] arm: tcg: only build under CONFIG_TCG Claudio Fontana
2021-03-12 17:22 ` [RFC v7 04/42] target/arm: tcg: add sysemu and user subsirs Claudio Fontana
2021-03-12 17:22 ` [RFC v7 05/42] target/arm: only build psci for TCG Claudio Fontana
2021-03-12 17:22 ` [RFC v7 06/42] target/arm: split off cpu-sysemu.c Claudio Fontana
2021-03-12 17:22 ` [RFC v7 07/42] target/arm: move physical address translation to cpu-mmu Claudio Fontana
2021-03-12 17:22 ` [RFC v7 08/42] target/arm: cpu-mmu: fix comment style Claudio Fontana
2021-03-12 17:22 ` [RFC v7 09/42] target/arm: split cpregs from tcg/helper.c Claudio Fontana
2021-03-12 17:22 ` [RFC v7 10/42] target/arm: cpregs: fix style (mostly just comments) Claudio Fontana
2021-03-12 17:22 ` [RFC v7 11/42] target/arm: move cpu definitions to common cpu module Claudio Fontana
2021-03-12 17:22 ` [RFC v7 12/42] target/arm: only perform TCG cpu and machine inits if TCG enabled Claudio Fontana
2021-03-12 17:22 ` [RFC v7 13/42] target/arm: kvm: add stubs for some helpers Claudio Fontana
2021-03-12 17:22 ` [RFC v7 14/42] target/arm: move cpsr_read, cpsr_write to cpu_common Claudio Fontana
2021-03-12 17:22 ` [RFC v7 15/42] target/arm: add temporary stub for arm_rebuild_hflags Claudio Fontana
2021-03-12 17:22 ` [RFC v7 16/42] target/arm: split vfp state setting from tcg helpers Claudio Fontana
2021-03-12 17:22 ` [RFC v7 17/42] target/arm: move arm_mmu_idx* to cpu-mmu Claudio Fontana
2021-03-12 17:22 ` [RFC v7 18/42] target/arm: move sve_zcr_len_for_el to common_cpu Claudio Fontana
2021-03-12 17:22 ` [RFC v7 19/42] target/arm: move arm_sctlr away from tcg helpers Claudio Fontana
2021-03-12 17:22 ` [RFC v7 20/42] target/arm: move arm_cpu_list to common_cpu Claudio Fontana
2021-03-12 17:22 ` [RFC v7 21/42] target/arm: move aarch64_sync_32_to_64 (and vv) to cpu code Claudio Fontana
2021-03-12 17:22 ` [RFC v7 22/42] target/arm: split a15 cpu model and 32bit class functions to cpu32.c Claudio Fontana
2021-03-12 17:22 ` [RFC v7 23/42] target/arm: move sve_exception_el out of TCG helpers Claudio Fontana
2021-03-12 17:22 ` [RFC v7 24/42] target/arm: refactor exception and cpu code Claudio Fontana
2021-03-12 17:22 ` Claudio Fontana [this message]
2021-03-12 17:22 ` [RFC v7 26/42] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled() Claudio Fontana
2021-03-12 17:22 ` [RFC v7 27/42] target/arm: remove kvm include file for PSCI and arm-powerctl Claudio Fontana
2021-03-12 17:22 ` [RFC v7 28/42] target/arm: move kvm-const.h, kvm.c, kvm64.c, kvm_arm.h to kvm/ Claudio Fontana
2021-03-12 17:22 ` [RFC v7 29/42] target/arm: cleanup cpu includes Claudio Fontana
2021-03-12 17:22 ` [RFC v7 30/42] target/arm: remove broad "else" statements when checking accels Claudio Fontana
2021-03-12 17:22 ` [RFC v7 31/42] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM Claudio Fontana
2021-03-12 17:22 ` [RFC v7 32/42] tests: restrict TCG-only arm-cpu-features tests to TCG builds Claudio Fontana
2021-03-12 17:22 ` [RFC v7 33/42] tests: do not run test-hmp on all machines for ARM KVM-only Claudio Fontana
2021-03-12 17:22 ` [RFC v7 34/42] tests: device-introspect-test: cope with ARM TCG-only devices Claudio Fontana
2021-03-12 17:22 ` [RFC v7 35/42] tests: do not run qom-test on all machines for ARM KVM-only Claudio Fontana
2021-03-12 17:22 ` [RFC v7 36/42] Revert "target/arm: Restrict v8M IDAU to TCG" Claudio Fontana
2021-03-12 17:22 ` [RFC v7 37/42] target/arm: create kvm cpu accel class Claudio Fontana
2021-03-12 17:22 ` [RFC v7 38/42] target/arm: move kvm cpu properties setting to kvm-cpu Claudio Fontana
2021-03-12 17:22 ` [RFC v7 39/42] accel: move call to accel_init_interfaces Claudio Fontana
2021-03-12 17:22 ` [RFC v7 40/42] accel: add double dispatch mechanism for class initialization Claudio Fontana
2021-03-12 17:22 ` [RFC v7 41/42] target/arm: add tcg cpu accel class Claudio Fontana
2021-03-12 17:28 ` Claudio Fontana
2021-03-12 17:22 ` [RFC v7 42/42] target/arm: move TCG gt timer creation code in tcg/ Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312172243.25334-26-cfontana@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).