From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: ivan@vmfacility.fr, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: [PATCH v2 03/15] target/ppc: Properly sync cpu state with new msr in cpu_load_old
Date: Fri, 12 Mar 2021 19:00:06 -0600 [thread overview]
Message-ID: <20210313010018.819153-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210313010018.819153-1-richard.henderson@linaro.org>
Match cpu_post_load in using ppc_store_msr to set all of
the cpu state implied by the value of msr. Do not restore
hflags or hflags_nmsr, as we recompute them in ppc_store_msr.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/ppc/machine.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/target/ppc/machine.c b/target/ppc/machine.c
index 283db1d28a..87d7bffb86 100644
--- a/target/ppc/machine.c
+++ b/target/ppc/machine.c
@@ -21,6 +21,7 @@ static int cpu_load_old(QEMUFile *f, void *opaque, int version_id)
int32_t slb_nr;
#endif
target_ulong xer;
+ target_ulong msr;
for (i = 0; i < 32; i++) {
qemu_get_betls(f, &env->gpr[i]);
@@ -111,11 +112,19 @@ static int cpu_load_old(QEMUFile *f, void *opaque, int version_id)
qemu_get_betls(f, &env->ivpr_mask);
qemu_get_betls(f, &env->hreset_vector);
qemu_get_betls(f, &env->nip);
- qemu_get_betls(f, &env->hflags);
- qemu_get_betls(f, &env->hflags_nmsr);
+ qemu_get_sbetl(f); /* Discard unused hflags */
+ qemu_get_sbetl(f); /* Discard unused hflags_nmsr */
qemu_get_sbe32(f); /* Discard unused mmu_idx */
qemu_get_sbe32(f); /* Discard unused power_mode */
+ /*
+ * Invalidate all supported msr bits except MSR_TGPR/MSR_HVB
+ * before restoring. Note that this recomputes hflags and mem_idx.
+ */
+ msr = env->msr;
+ env->msr ^= env->msr_mask & ~((1ULL << MSR_TGPR) | MSR_HVB);
+ ppc_store_msr(env, msr);
+
/* Recompute mmu indices */
hreg_compute_mem_idx(env);
--
2.25.1
next prev parent reply other threads:[~2021-03-13 1:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 1:00 [PATCH v2 00/15] target/ppc: Fix truncation of env->hflags Richard Henderson
2021-03-13 1:00 ` [PATCH v2 01/15] target/ppc: Move helper_regs.h functions out-of-line Richard Henderson
2021-03-13 1:00 ` [PATCH v2 02/15] target/ppc: Move 601 hflags adjustment to hreg_compute_hflags Richard Henderson
2021-03-13 1:00 ` Richard Henderson [this message]
2021-03-13 1:00 ` [PATCH v2 04/15] target/ppc: Do not call hreg_compute_mem_idx after ppc_store_msr Richard Henderson
2021-03-13 1:00 ` [PATCH v2 05/15] target/ppc: Retain hflags_nmsr only for migration Richard Henderson
2021-03-13 1:00 ` [PATCH v2 06/15] target/ppc: Fix comment for MSR_FE{0,1} Richard Henderson
2021-03-13 1:00 ` [PATCH v2 07/15] target/ppc: Disconnect hflags from MSR Richard Henderson
2021-03-13 1:00 ` [PATCH v2 08/15] target/ppc: Reduce env->hflags to uint32_t Richard Henderson
2021-03-13 1:00 ` [PATCH v2 09/15] target/ppc: Put dbcr0 single-step bits into hflags Richard Henderson
2021-03-13 1:00 ` [PATCH v2 10/15] target/ppc: Create helper_scv Richard Henderson
2021-03-13 1:00 ` [PATCH v2 11/15] target/ppc: Put LPCR[GTSE] in hflags Richard Henderson
2021-03-13 1:00 ` [PATCH v2 12/15] target/ppc: Remove MSR_SA and MSR_AP from hflags Richard Henderson
2021-03-13 1:00 ` [PATCH v2 13/15] target/ppc: Remove env->immu_idx and env->dmmu_idx Richard Henderson
2021-03-13 1:00 ` [PATCH v2 14/15] hw/ppc: Use hreg_store_msr for msr updates Richard Henderson
2021-03-13 1:00 ` [PATCH v2 15/15] target/ppc: Validate hflags with CONFIG_DEBUG_TCG Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313010018.819153-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=ivan@vmfacility.fr \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).