* [PATCH] include/ui/console.h: Delete is_surface_bgr()
@ 2021-03-14 16:39 Peter Maydell
2021-03-14 21:59 ` Philippe Mathieu-Daudé
2021-03-17 9:58 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2021-03-14 16:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
The function is_surface_bgr() is no longer used anywhere,
so we can delete it.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
include/ui/console.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index c960b7066cc..810ce7988c0 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -267,16 +267,6 @@ PixelFormat qemu_default_pixelformat(int bpp);
DisplaySurface *qemu_create_displaysurface(int width, int height);
void qemu_free_displaysurface(DisplaySurface *surface);
-static inline int is_surface_bgr(DisplaySurface *surface)
-{
- if (PIXMAN_FORMAT_BPP(surface->format) == 32 &&
- PIXMAN_FORMAT_TYPE(surface->format) == PIXMAN_TYPE_ABGR) {
- return 1;
- } else {
- return 0;
- }
-}
-
static inline int is_buffer_shared(DisplaySurface *surface)
{
return !(surface->flags & QEMU_ALLOCATED_FLAG);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] include/ui/console.h: Delete is_surface_bgr()
2021-03-14 16:39 [PATCH] include/ui/console.h: Delete is_surface_bgr() Peter Maydell
@ 2021-03-14 21:59 ` Philippe Mathieu-Daudé
2021-03-17 9:58 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-14 21:59 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Gerd Hoffmann
On 3/14/21 5:39 PM, Peter Maydell wrote:
> The function is_surface_bgr() is no longer used anywhere,
> so we can delete it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/ui/console.h | 10 ----------
> 1 file changed, 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include/ui/console.h: Delete is_surface_bgr()
2021-03-14 16:39 [PATCH] include/ui/console.h: Delete is_surface_bgr() Peter Maydell
2021-03-14 21:59 ` Philippe Mathieu-Daudé
@ 2021-03-17 9:58 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2021-03-17 9:58 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel
On Sun, Mar 14, 2021 at 04:39:27PM +0000, Peter Maydell wrote:
> The function is_surface_bgr() is no longer used anywhere,
> so we can delete it.
Added to (6.1) ui queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-14 16:39 [PATCH] include/ui/console.h: Delete is_surface_bgr() Peter Maydell
2021-03-14 21:59 ` Philippe Mathieu-Daudé
2021-03-17 9:58 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).