qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: "Jason Wang" <jasowang@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org
Cc: Bin Meng <bmeng.cn@gmail.com>
Subject: [PATCH v2 04/13] net: tap: Pad short frames to minimum size before send
Date: Mon, 15 Mar 2021 15:57:09 +0800	[thread overview]
Message-ID: <20210315075718.5402-5-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20210315075718.5402-1-bmeng.cn@gmail.com>

Do the same for tap backend as what we did for slirp.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 net/tap-win32.c | 12 ++++++++++++
 net/tap.c       | 12 ++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/net/tap-win32.c b/net/tap-win32.c
index 2b5dcda36e..ec35ab8ce7 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -31,6 +31,7 @@
 
 #include "qemu-common.h"
 #include "clients.h"            /* net_init_tap */
+#include "net/eth.h"
 #include "net/net.h"
 #include "net/tap.h"            /* tap_has_ufo, ... */
 #include "qemu/error-report.h"
@@ -688,9 +689,20 @@ static void tap_win32_send(void *opaque)
     uint8_t *buf;
     int max_size = 4096;
     int size;
+    uint8_t min_buf[ETH_ZLEN];
 
     size = tap_win32_read(s->handle, &buf, max_size);
     if (size > 0) {
+        if (!s->nc.peer->do_not_pad) {
+            /* Pad to minimum Ethernet frame length */
+            if (size < ETH_ZLEN) {
+                memcpy(min_buf, buf, size);
+                memset(&min_buf[size], 0, ETH_ZLEN - size);
+                buf = min_buf;
+                size = ETH_ZLEN;
+            }
+        }
+
         qemu_send_packet(&s->nc, buf, size);
         tap_win32_free_buffer(s->handle, buf);
     }
diff --git a/net/tap.c b/net/tap.c
index b7512853f4..f96b1ccfc0 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -32,6 +32,7 @@
 #include <sys/socket.h>
 #include <net/if.h>
 
+#include "net/eth.h"
 #include "net/net.h"
 #include "clients.h"
 #include "monitor/monitor.h"
@@ -189,6 +190,7 @@ static void tap_send(void *opaque)
 
     while (true) {
         uint8_t *buf = s->buf;
+        uint8_t min_buf[ETH_ZLEN];
 
         size = tap_read_packet(s->fd, s->buf, sizeof(s->buf));
         if (size <= 0) {
@@ -200,6 +202,16 @@ static void tap_send(void *opaque)
             size -= s->host_vnet_hdr_len;
         }
 
+        if (!s->nc.peer->do_not_pad) {
+            /* Pad to minimum Ethernet frame length */
+            if (size < ETH_ZLEN) {
+                memcpy(min_buf, buf, size);
+                memset(&min_buf[size], 0, ETH_ZLEN - size);
+                buf = min_buf;
+                size = ETH_ZLEN;
+            }
+        }
+
         size = qemu_send_packet_async(&s->nc, buf, size, tap_send_completed);
         if (size == 0) {
             tap_read_poll(s, false);
-- 
2.25.1



  parent reply	other threads:[~2021-03-15  8:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15  7:57 [PATCH v2 00/13] net: Pad short frames for network backends Bin Meng
2021-03-15  7:57 ` [PATCH v2 01/13] net: Add ETH_ZLEN define in eth.h Bin Meng
2021-03-15  9:13   ` Philippe Mathieu-Daudé
2021-03-15 10:15     ` Bin Meng
2021-03-15 10:24       ` Philippe Mathieu-Daudé
2021-03-15  7:57 ` [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState Bin Meng
2021-03-15  9:17   ` Philippe Mathieu-Daudé
2021-03-15  9:18     ` Philippe Mathieu-Daudé
2021-03-15  9:22       ` Philippe Mathieu-Daudé
2021-03-15 10:17         ` Bin Meng
2021-03-15 10:21           ` Peter Maydell
2021-03-15  7:57 ` [PATCH v2 03/13] net: slirp: Pad short frames to minimum size before send Bin Meng
2021-03-16  2:25   ` Jason Wang
2021-03-15  7:57 ` Bin Meng [this message]
2021-03-15  7:57 ` [PATCH v2 05/13] hw/net: virtio-net: Initialize nc->do_not_pad to true Bin Meng
2021-03-15  7:57 ` [PATCH v2 06/13] hw/net: e1000: Remove the logic of padding short frames in the receive path Bin Meng
2021-03-15  7:57 ` [PATCH v2 07/13] hw/net: vmxnet3: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 08/13] hw/net: i82596: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 09/13] hw/net: ne2000: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 10/13] hw/net: pcnet: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 11/13] hw/net: rtl8139: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 12/13] hw/net: sungem: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 13/13] hw/net: sunhme: " Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315075718.5402-5-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).