From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1BAAC433E0 for ; Mon, 15 Mar 2021 11:55:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D30264E90 for ; Mon, 15 Mar 2021 11:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D30264E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLlp7-0005Cp-FX for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 07:55:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLlnj-0004dd-9f for qemu-devel@nongnu.org; Mon, 15 Mar 2021 07:54:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLlnh-0002HX-Nw for qemu-devel@nongnu.org; Mon, 15 Mar 2021 07:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615809261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jWGYH8nfIerffoG4f2iFEpUs8wlGWlS4x1yGycxGMas=; b=Qh90ff7rb8Mc6kz4MghIj/dPNtTiNQwqgTNU+/+Fu/TiQSOiKRvfkN+4/91MTy3YSH6Apa spqG+zRww3//PsXcsKh/ahFdDaZjPRNKOpcVMQasaTa5OJvNW5iMvxWJROlgOI0tX8RYr2 4RFSQS5tDxwcMiGDQ4o6kh9t8m2W6A8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-HBT-_vxDORaNw6IR5cipOg-1; Mon, 15 Mar 2021 07:54:15 -0400 X-MC-Unique: HBT-_vxDORaNw6IR5cipOg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F72D100C663; Mon, 15 Mar 2021 11:54:14 +0000 (UTC) Received: from localhost (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93725620DE; Mon, 15 Mar 2021 11:54:05 +0000 (UTC) Date: Mon, 15 Mar 2021 12:54:03 +0100 From: Igor Mammedov To: David Hildenbrand Subject: Re: [PATCH v3 4/4] acpi: Set proper maximum size for "etc/acpi/rsdp" blob Message-ID: <20210315125403.68ef8925@redhat.com> In-Reply-To: <20210304105554.121674-5-david@redhat.com> References: <20210304105554.121674-1-david@redhat.com> <20210304105554.121674-5-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Alistair Francis , Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Laszlo Ersek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 4 Mar 2021 11:55:54 +0100 David Hildenbrand wrote: > Let's also set a maximum size for "etc/acpi/rsdp", so the maximum > size doesn't get implicitly set based on the initial table size. In my > experiments, the table size was in the range of 22 bytes, so a single > page (== what we used until now) seems to be good enough. > > Now that we have defined maximum sizes for all currently used table types, > let's assert that we catch usage with new tables that need a proper maximum > size definition. > > Also assert that our initial size does not exceed the maximum size; while > qemu_ram_alloc_internal() properly asserts that the initial RAMBlock size > is <= its maximum size, the result might differ when the host page size > is bigger than 4k. > > Suggested-by: Laszlo Ersek > Cc: Alistair Francis > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Peter Maydell > Cc: Shannon Zhao > Cc: Marcel Apfelbaum > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Laszlo Ersek > Signed-off-by: David Hildenbrand > --- > hw/acpi/utils.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/acpi/utils.c b/hw/acpi/utils.c > index f2d69a6d92..0c486ea29f 100644 > --- a/hw/acpi/utils.c > +++ b/hw/acpi/utils.c > @@ -29,14 +29,19 @@ > MemoryRegion *acpi_add_rom_blob(FWCfgCallback update, void *opaque, > GArray *blob, const char *name) > { > - uint64_t max_size = 0; > + uint64_t max_size; [...] > + } else { > + g_assert_not_reached(); > } > + g_assert(acpi_data_len(blob) <= max_size); though it's correct, but theoretically compiler might get unhappy about uninitialized max_size here though if it compiles fine with our current CI it should be good enough > > return rom_add_blob(name, blob->data, acpi_data_len(blob), max_size, -1, > name, update, opaque, NULL, true);