From: Joelle van Dyne <j@getutm.app>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>, "Joelle van Dyne" <j@getutm.app>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 2/4] block: check for sys/disk.h
Date: Mon, 15 Mar 2021 11:03:39 -0700 [thread overview]
Message-ID: <20210315180341.31638-3-j@getutm.app> (raw)
In-Reply-To: <20210315180341.31638-1-j@getutm.app>
Some BSD platforms do not have this header.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Joelle van Dyne <j@getutm.app>
---
meson.build | 1 +
block.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 59c7c56366..2c01e2494c 100644
--- a/meson.build
+++ b/meson.build
@@ -1153,6 +1153,7 @@ config_host_data.set('HAVE_SYS_IOCCOM_H', cc.has_header('sys/ioccom.h'))
config_host_data.set('HAVE_SYS_KCOV_H', cc.has_header('sys/kcov.h'))
config_host_data.set('HAVE_SYSTEM_FUNCTION', cc.has_function('system', prefix: '#include <stdlib.h>'))
config_host_data.set('HAVE_HOST_BLOCK_DEVICE', have_host_block_device)
+config_host_data.set('HAVE_SYS_DISK_H', cc.has_header('sys/disk.h'))
config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
diff --git a/block.c b/block.c
index f377158c42..c9729bdf21 100644
--- a/block.c
+++ b/block.c
@@ -54,7 +54,7 @@
#ifdef CONFIG_BSD
#include <sys/ioctl.h>
#include <sys/queue.h>
-#ifndef __DragonFly__
+#if defined(HAVE_SYS_DISK_H)
#include <sys/disk.h>
#endif
#endif
--
2.28.0
next prev parent reply other threads:[~2021-03-15 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 18:03 [PATCH v3 0/4] Disable unsupported features on iOS hosts Joelle van Dyne
2021-03-15 18:03 ` [PATCH v3 1/4] block: feature detection for host block support Joelle van Dyne
2021-03-22 17:31 ` Joelle van Dyne
2021-03-15 18:03 ` Joelle van Dyne [this message]
2021-04-01 5:08 ` [PATCH v3 2/4] block: check for sys/disk.h Joelle van Dyne
2021-04-01 8:03 ` Philippe Mathieu-Daudé
2021-04-01 8:58 ` Paolo Bonzini
2021-03-15 18:03 ` [PATCH v3 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use Joelle van Dyne
2021-03-15 18:03 ` [PATCH v3 4/4] slirp: feature detection for smbd Joelle van Dyne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315180341.31638-3-j@getutm.app \
--to=j@getutm.app \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).