From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C944BC433DB for ; Mon, 15 Mar 2021 17:34:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E7CD64F06 for ; Mon, 15 Mar 2021 17:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E7CD64F06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLr7I-0007EW-4M for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 13:34:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLr4e-0005QI-Mx for qemu-devel@nongnu.org; Mon, 15 Mar 2021 13:32:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLr4c-00048N-5V for qemu-devel@nongnu.org; Mon, 15 Mar 2021 13:32:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615829529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIDOd9W5XbJXp6f8PXV1cuJovu5SKnvhyuxw9hOgUFw=; b=Prv+ObWXvs2zXatOLFnC0g8L0bq1sezhvHbdqSghVzgT035F1d74SNSHMsg1oaJAV1Jct9 s12sM4aU7SRejwbE5tmbZAAZbxTAPVjSt6mMUi6bzwdmkz9nMr2RLbIzG2At8p6TfxjKU5 k6lpJB7guyJosiost4TFxgpzcDWRRkk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-ylfuJVsePUaVUIU94nyKWA-1; Mon, 15 Mar 2021 13:32:06 -0400 X-MC-Unique: ylfuJVsePUaVUIU94nyKWA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 702EC1966321 for ; Mon, 15 Mar 2021 17:32:05 +0000 (UTC) Received: from gondolin (ovpn-113-87.ams2.redhat.com [10.36.113.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8BF5019D7C; Mon, 15 Mar 2021 17:32:04 +0000 (UTC) Date: Mon, 15 Mar 2021 18:32:01 +0100 From: Cornelia Huck To: mrezanin@redhat.com Subject: Re: [PATCH v3] Add missing initialization for g_autofree variables Message-ID: <20210315183201.023769e9.cohuck@redhat.com> In-Reply-To: <20210315101352.152888-1-mrezanin@redhat.com> References: <20210315101352.152888-1-mrezanin@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 15 Mar 2021 11:13:52 +0100 mrezanin@redhat.com wrote: > From: Miroslav Rezanina > > When declaring g_autofree variable without inicialization, compiler > will raise "may be used uninitialized in this function" warning due > to automatic free handling. > > This is mentioned in docs/devel/style.rst (quote from section > "Automatic memory deallocation"): > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > Add inicialization for these declarations to prevent the warning and > comply with coding style. > > Signed-off-by: Miroslav Rezanina > > --- > * v3: > -- allocate in s390_pci_update_dma_avail instead of NULL init > > * v2: > -- Removed fixes in hw/remote/memory.c and hw/remote/proxy.c > fixed by patch sent by Zenghui Yu (multi-process: Initialize > variables declared with g_auto*) > --- > hw/s390x/s390-pci-vfio.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c > index ead4f222d5..2a153fa8c9 100644 > --- a/hw/s390x/s390-pci-vfio.c > +++ b/hw/s390x/s390-pci-vfio.c > @@ -29,14 +29,11 @@ > */ > bool s390_pci_update_dma_avail(int fd, unsigned int *avail) > { > - g_autofree struct vfio_iommu_type1_info *info; > - uint32_t argsz; > + uint32_t argsz = sizeof(struct vfio_iommu_type1_info); > + g_autofree struct vfio_iommu_type1_info *info = g_malloc0(argsz); > > assert(avail); > > - argsz = sizeof(struct vfio_iommu_type1_info); > - info = g_malloc0(argsz); > - > /* > * If the specified argsz is not large enough to contain all capabilities > * it will be updated upon return from the ioctl. Retry until we have > @@ -230,7 +227,7 @@ static void s390_pci_read_pfip(S390PCIBusDevice *pbdev, > */ > void s390_pci_get_clp_info(S390PCIBusDevice *pbdev) > { > - g_autofree struct vfio_device_info *info; > + g_autofree struct vfio_device_info *info = NULL; > VFIOPCIDevice *vfio_pci; > uint32_t argsz; > int fd; Thanks, applied.