From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A973BC433DB for ; Mon, 15 Mar 2021 17:57:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4804764F09 for ; Mon, 15 Mar 2021 17:57:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4804764F09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLrTH-0005Pz-9y for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 13:57:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLrOw-0000Bm-KZ for qemu-devel@nongnu.org; Mon, 15 Mar 2021 13:53:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLrOu-0004ac-QD for qemu-devel@nongnu.org; Mon, 15 Mar 2021 13:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615830788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rQ1y1NbAN6NWJorikiGHrulMTl5oJw4tpprNS+f05Zo=; b=JyzK1j5qJnde3Hx8gnthlcSynV7SVNZM217pOSCgci9rd2oqN5ew3gajfQ+IVGzkHWq3g0 KUKOHcTopkSDrtMkYqadFrSCfYkgFXNTxRXWBluqcki3EbQAUiuPoaYRP1yg0bJWizFFRA wxAppb4vWy/QJM6Q/s/RBaxPoPW4Qfo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-vR7IE-zpO6Kz1ScyFW1gGQ-1; Mon, 15 Mar 2021 13:53:06 -0400 X-MC-Unique: vR7IE-zpO6Kz1ScyFW1gGQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 361AF192D787; Mon, 15 Mar 2021 17:53:05 +0000 (UTC) Received: from localhost (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62D0710023B5; Mon, 15 Mar 2021 17:53:04 +0000 (UTC) Date: Mon, 15 Mar 2021 18:53:02 +0100 From: Igor Mammedov To: Reinoud Zandijk Subject: Re: Windows 10 won't run on default x86_64 machine anymore Message-ID: <20210315185302.29b0d90d@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 15 Mar 2021 17:58:04 +0100 Reinoud Zandijk wrote: > Hi, > > with the introduction of the following patch from 17th of February, Win10 > won't boot anymore without explicitly setting the machine to be 5.2 compatible > like pc-1440fx-5.2. The default 6.0 will cause it to panic and gives as reason > only "ACPI error". > > It might work to counter a bug in Linux but this is not the place to do the > patch. The BSDs don't care and will boot fine with full ACPI regardless of the > machine chosen. Windows 10 however DOES care and gets confused. > > I think its better to revert this and fix Linux ;) or make it a selectable > feature as a workaround that's by default OFF :) Windows 10 1607x64 boots fine when I test it with default machine. So 1) can you provide full QEMU command line used 2) What Windows build do you use 3) is it existing guest image (i.e. installed in older QEMU version) > With regards, > Reinoud > > > The patch concerned is: > > commit 6be8cf56bc8bda2ed9a070bdb04446191f31acc9 > Author: Isaku Yamahata > Date: Wed Feb 17 21:51:12 2021 -0800 > > acpi/core: always set SCI_EN when SMM isn't supported > > If SMM is not supported, ACPI fixed hardware doesn't support > legacy-mode. ACPI-only platform. Where SCI_EN in PM1_CNT register is > always set. > The bit tells OS legacy mode(SCI_EN cleared) or ACPI mode(SCI_EN set). > > With the next patch (setting fadt.smi_cmd = 0 when smm isn't enabled), > guest Linux tries to switch to ACPI mode, finds smi_cmd = 0, and then > fails to initialize acpi subsystem. This patch proactively fixes it. > > This patch changes guest ABI. To keep compatibility, use > "smm-compat" introduced by earlier patch. If the property is true, > disable new behavior. > > ACPI spec 4.8.10.1 PM1 Event Grouping > PM1 Eanble Registers > > For ACPI-only platforms (where SCI_EN is always set) > > Reviewed-by: Igor Mammedov > Signed-off-by: Isaku Yamahata > Message-Id: > <500f62081626997e46f96377393d3662211763a8.1613615732.git.isaku.yamahata@intel.com> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > > hw/acpi/core.c | 11 ++++++++++- > hw/acpi/ich9.c | 2 +- > hw/acpi/piix4.c | 3 ++- > hw/core/machine.c | 5 ++++- > hw/isa/vt82c686.c | 2 +- > include/hw/acpi/acpi.h | 4 +++- > 6 files changed, 21 insertions(+), 6 deletions(-) > >