From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, groug@kaod.org, vgoyal@redhat.com,
wanghao232@huawei.com, ma.mandourr@gmail.com
Cc: stefanha@redhat.com, peterx@redhat.com, quintela@redhat.com
Subject: [PULL 9/9] migration: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD
Date: Mon, 15 Mar 2021 20:12:15 +0000 [thread overview]
Message-ID: <20210315201215.222539-10-dgilbert@redhat.com> (raw)
In-Reply-To: <20210315201215.222539-1-dgilbert@redhat.com>
From: Mahmoud Mandour <ma.mandourr@gmail.com>
Replaced various qemu_mutex_lock calls and their respective
qemu_mutex_unlock calls with QEMU_LOCK_GUARD macro. This simplifies
the code by eliminating the respective qemu_mutex_unlock calls.
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Message-Id: <20210311031538.5325-7-ma.mandourr@gmail.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 6 ++----
migration/ram.c | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index a5ddf43559..36768391b6 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -323,7 +323,7 @@ static int migrate_send_rp_message(MigrationIncomingState *mis,
int ret = 0;
trace_migrate_send_rp_message((int)message_type, len);
- qemu_mutex_lock(&mis->rp_mutex);
+ QEMU_LOCK_GUARD(&mis->rp_mutex);
/*
* It's possible that the file handle got lost due to network
@@ -331,7 +331,7 @@ static int migrate_send_rp_message(MigrationIncomingState *mis,
*/
if (!mis->to_src_file) {
ret = -EIO;
- goto error;
+ return ret;
}
qemu_put_be16(mis->to_src_file, (unsigned int)message_type);
@@ -342,8 +342,6 @@ static int migrate_send_rp_message(MigrationIncomingState *mis,
/* It's possible that qemu file got error during sending */
ret = qemu_file_get_error(mis->to_src_file);
-error:
- qemu_mutex_unlock(&mis->rp_mutex);
return ret;
}
diff --git a/migration/ram.c b/migration/ram.c
index 72143da0ac..52537f14ac 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -819,7 +819,7 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs,
{
bool ret;
- qemu_mutex_lock(&rs->bitmap_mutex);
+ QEMU_LOCK_GUARD(&rs->bitmap_mutex);
/*
* Clear dirty bitmap if needed. This _must_ be called before we
@@ -852,7 +852,6 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs,
if (ret) {
rs->migration_dirty_pages--;
}
- qemu_mutex_unlock(&rs->bitmap_mutex);
return ret;
}
@@ -3275,7 +3274,7 @@ static void decompress_data_with_multi_threads(QEMUFile *f,
int idx, thread_count;
thread_count = migrate_decompress_threads();
- qemu_mutex_lock(&decomp_done_lock);
+ QEMU_LOCK_GUARD(&decomp_done_lock);
while (true) {
for (idx = 0; idx < thread_count; idx++) {
if (decomp_param[idx].done) {
@@ -3295,7 +3294,6 @@ static void decompress_data_with_multi_threads(QEMUFile *f,
qemu_cond_wait(&decomp_done_cond, &decomp_done_lock);
}
}
- qemu_mutex_unlock(&decomp_done_lock);
}
/*
--
2.30.2
next prev parent reply other threads:[~2021-03-15 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 20:12 [PULL 0/9] virtiofs and migration queue Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 1/9] virtiofsd: Release vu_dispatch_lock when stopping queue Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 2/9] virtiofsd: Add qemu version and copyright info Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 3/9] virtiofsd: Don't allow empty filenames Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 4/9] virtiofsd: Don't allow empty paths in lookup_name() Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 5/9] virtiofsd: Convert some functions to return bool Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 6/9] migration/tls: fix inverted semantics in multifd_channel_connect Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 7/9] migration/tls: add error handling in multifd_tls_handshake_thread Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 8/9] monitor: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` Dr. David Alan Gilbert (git) [this message]
2021-03-17 10:37 ` [PULL 0/9] virtiofs and migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315201215.222539-10-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=ma.mandourr@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=wanghao232@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).