qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, groug@kaod.org, vgoyal@redhat.com,
	wanghao232@huawei.com, ma.mandourr@gmail.com
Cc: stefanha@redhat.com, peterx@redhat.com, quintela@redhat.com
Subject: [PULL 5/9] virtiofsd: Convert some functions to return bool
Date: Mon, 15 Mar 2021 20:12:11 +0000	[thread overview]
Message-ID: <20210315201215.222539-6-dgilbert@redhat.com> (raw)
In-Reply-To: <20210315201215.222539-1-dgilbert@redhat.com>

From: Greg Kurz <groug@kaod.org>

Both currently only return 0 or 1.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210312141003.819108-3-groug@kaod.org>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tools/virtiofsd/passthrough_ll.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index cf453eea9b..b144320e48 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -223,17 +223,17 @@ static struct lo_inode *lo_find(struct lo_data *lo, struct stat *st,
 static int xattr_map_client(const struct lo_data *lo, const char *client_name,
                             char **out_name);
 
-static int is_dot_or_dotdot(const char *name)
+static bool is_dot_or_dotdot(const char *name)
 {
     return name[0] == '.' &&
            (name[1] == '\0' || (name[1] == '.' && name[2] == '\0'));
 }
 
 /* Is `path` a single path component that is not "." or ".."? */
-static int is_safe_path_component(const char *path)
+static bool is_safe_path_component(const char *path)
 {
     if (strchr(path, '/')) {
-        return 0;
+        return false;
     }
 
     return !is_dot_or_dotdot(path);
-- 
2.30.2



  parent reply	other threads:[~2021-03-15 20:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 20:12 [PULL 0/9] virtiofs and migration queue Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 1/9] virtiofsd: Release vu_dispatch_lock when stopping queue Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 2/9] virtiofsd: Add qemu version and copyright info Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 3/9] virtiofsd: Don't allow empty filenames Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 4/9] virtiofsd: Don't allow empty paths in lookup_name() Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` Dr. David Alan Gilbert (git) [this message]
2021-03-15 20:12 ` [PULL 6/9] migration/tls: fix inverted semantics in multifd_channel_connect Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 7/9] migration/tls: add error handling in multifd_tls_handshake_thread Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 8/9] monitor: Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD Dr. David Alan Gilbert (git)
2021-03-15 20:12 ` [PULL 9/9] migration: " Dr. David Alan Gilbert (git)
2021-03-17 10:37 ` [PULL 0/9] virtiofs and migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315201215.222539-6-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=groug@kaod.org \
    --cc=ma.mandourr@gmail.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=wanghao232@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).