qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	vivek.kasireddy@intel.com, tina.zhang@intel.com
Subject: [PATCH 07/15] virtio-gpu: use class function for ctrl queue handlers
Date: Fri, 19 Mar 2021 12:21:39 +0100	[thread overview]
Message-ID: <20210319112147.4138943-8-kraxel@redhat.com> (raw)
In-Reply-To: <20210319112147.4138943-1-kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/hw/virtio/virtio-gpu.h |  8 +++++++-
 hw/display/virtio-gpu.c        | 12 +++++++++---
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index a7b7d78310ea..380aa7dd6322 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -29,7 +29,7 @@ OBJECT_DECLARE_TYPE(VirtIOGPUBase, VirtIOGPUBaseClass,
                     VIRTIO_GPU_BASE)
 
 #define TYPE_VIRTIO_GPU "virtio-gpu-device"
-OBJECT_DECLARE_SIMPLE_TYPE(VirtIOGPU, VIRTIO_GPU)
+OBJECT_DECLARE_TYPE(VirtIOGPU, VirtIOGPUClass, VIRTIO_GPU)
 
 #define TYPE_VIRTIO_GPU_GL "virtio-gpu-gl-device"
 OBJECT_DECLARE_SIMPLE_TYPE(VirtIOGPUGL, VIRTIO_GPU_GL)
@@ -166,6 +166,12 @@ struct VirtIOGPU {
     } stats;
 };
 
+struct VirtIOGPUClass {
+    VirtIOGPUBaseClass parent;
+
+    void (*handle_ctrl)(VirtIODevice *vdev, VirtQueue *vq);
+};
+
 struct VirtIOGPUGL {
     struct VirtIOGPU parent_obj;
 };
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 68286f75a01a..39ef22b7c08d 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -893,7 +893,9 @@ static void virtio_gpu_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq)
 static void virtio_gpu_ctrl_bh(void *opaque)
 {
     VirtIOGPU *g = opaque;
-    virtio_gpu_handle_ctrl(&g->parent_obj.parent_obj, g->ctrl_vq);
+    VirtIOGPUClass *vgc = VIRTIO_GPU_GET_CLASS(g);
+
+    vgc->handle_ctrl(&g->parent_obj.parent_obj, g->ctrl_vq);
 }
 
 static void virtio_gpu_handle_cursor(VirtIODevice *vdev, VirtQueue *vq)
@@ -1210,9 +1212,12 @@ static void virtio_gpu_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
-    VirtIOGPUBaseClass *vgc = VIRTIO_GPU_BASE_CLASS(klass);
+    VirtIOGPUBaseClass *vbc = VIRTIO_GPU_BASE_CLASS(klass);
+    VirtIOGPUClass *vgc = VIRTIO_GPU_CLASS(klass);
+
+    vbc->gl_flushed = virtio_gpu_gl_flushed;
+    vgc->handle_ctrl = virtio_gpu_handle_ctrl;
 
-    vgc->gl_flushed = virtio_gpu_gl_flushed;
     vdc->realize = virtio_gpu_device_realize;
     vdc->reset = virtio_gpu_reset;
     vdc->get_config = virtio_gpu_get_config;
@@ -1226,6 +1231,7 @@ static const TypeInfo virtio_gpu_info = {
     .name = TYPE_VIRTIO_GPU,
     .parent = TYPE_VIRTIO_GPU_BASE,
     .instance_size = sizeof(VirtIOGPU),
+    .class_size = sizeof(VirtIOGPUClass),
     .class_init = virtio_gpu_class_init,
 };
 
-- 
2.30.2



  parent reply	other threads:[~2021-03-19 11:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 11:21 [PATCH 00/15] virtio-gpu: split into two devices Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 01/15] virtio-gpu: rename virgl source file Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 02/15] virtio-gpu: add virtio-gpu-gl-device Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 03/15] virtio-gpu: add virtio-gpu-gl-pci Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 04/15] virtio-gpu: add virtio-vga-gl Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 05/15] virtio-gpu: move virgl realize + properties Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 06/15] virtio-gpu: move virgl reset Gerd Hoffmann
2021-03-19 11:21 ` Gerd Hoffmann [this message]
2021-03-19 11:21 ` [PATCH 08/15] virtio-gpu: move virgl handle_ctrl Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 09/15] virtio-gpu: move virgl gl_flushed Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 10/15] virtio-gpu: move virgl process_cmd Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 11/15] virtio-gpu: move update_cursor_data Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 12/15] virtio-gpu: drop VIRGL() macro Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 13/15] virtio-gpu: move virtio-gpu-gl-device to separate module Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 14/15] virtio-gpu: drop use_virgl_renderer Gerd Hoffmann
2021-03-19 11:21 ` [PATCH 15/15] virtio-gpu: move fields to struct VirtIOGPUGL Gerd Hoffmann
2021-03-19 11:42 ` [PATCH 00/15] virtio-gpu: split into two devices no-reply
2021-03-19 11:48 ` Marc-André Lureau
2021-03-22  8:14   ` Gerd Hoffmann
2021-03-22 18:41     ` Kasireddy, Vivek
2021-03-23  8:18       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210319112147.4138943-8-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tina.zhang@intel.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).