From: Halil Pasic <pasic@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Boris Fiuczynski" <fiuczy@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Bin Meng" <bin.meng@windriver.com>,
qemu-devel@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Anup Patel" <anup@brainfault.org>,
"Bruce Rogers" <brogers@suse.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Palmer Dabbelt" <palmerdabbelt@google.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Alejandro Jimenez" <alejandro.j.jimenez@oracle.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 1/2] modules: introduce target specific modules
Date: Fri, 19 Mar 2021 16:27:19 +0100 [thread overview]
Message-ID: <20210319162719.5779e251.pasic@linux.ibm.com> (raw)
In-Reply-To: <9b103263-c3fa-79b9-5ff7-349bfbf60d78@redhat.com>
On Thu, 18 Mar 2021 12:36:48 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> > diff --git a/roms/SLOF b/roms/SLOF
> > index 33a7322de1..e18ddad851 160000
> > --- a/roms/SLOF
> > +++ b/roms/SLOF
> > @@ -1 +1 @@
> > -Subproject commit 33a7322de13e9dca4b38851a345a58d37e7a441d
> > +Subproject commit e18ddad8516ff2cfe36ec130200318f7251aa78c
> > diff --git a/roms/opensbi b/roms/opensbi
> > index 234ed8e427..a98258d0b5 160000
> > --- a/roms/opensbi
> > +++ b/roms/opensbi
> > @@ -1 +1 @@
> > -Subproject commit 234ed8e427f4d92903123199f6590d144e0d9351
> > +Subproject commit a98258d0b537a295f517bbc8d813007336731fa9
>
> While your patch deals with "target modules", the 2 submodule
> changes are unrelated, right?
Hi Philippe!
Not only unrelated but also unintentional. Seems I was not careful
enough with "git add -u". Should we decide to go in this direction
(symlinks) I will make sure to drop these changes next time.
Regards,
Halil
next prev parent reply other threads:[~2021-03-19 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:26 [RFC PATCH 0/2] hw/s390x: modularize virtio-gpu-ccw Halil Pasic
2021-03-16 12:26 ` [RFC PATCH 1/2] modules: introduce target specific modules Halil Pasic
2021-03-18 11:36 ` Philippe Mathieu-Daudé
2021-03-19 15:27 ` Halil Pasic [this message]
2021-03-16 12:26 ` [RFC PATCH 2/2] hw/s390x: modularize virtio-gpu-ccw Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319162719.5779e251.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=alejandro.j.jimenez@oracle.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=anup@brainfault.org \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=borntraeger@de.ibm.com \
--cc=brogers@suse.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=palmerdabbelt@google.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).