From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 204FDC433DB for ; Fri, 19 Mar 2021 15:28:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 848EE61930 for ; Fri, 19 Mar 2021 15:28:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 848EE61930 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNH34-0005xI-G7 for qemu-devel@archiver.kernel.org; Fri, 19 Mar 2021 11:28:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNH2I-00055a-8X; Fri, 19 Mar 2021 11:27:38 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52262 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNH2G-0000Xp-Ha; Fri, 19 Mar 2021 11:27:38 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12JFEYix084582; Fri, 19 Mar 2021 11:27:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=OHUlDg4N1k2TM7haoY+3V19DKiU8r0pc/bS5MbDTY+w=; b=badC218pVxl6AQdirChR7rgO5lWnjy2RmnsE2E79td3d9rYymFcYOTO0bsoZX5FgT/pT W8K/lAdIWFEkzwnaYVWdVNv0q0uX0BuEsF0PzMaPgfUC4eGqWt0QDHvv2vPy9/sYvVV8 53cpePVEXDUeSZP7Vl3KAkq/a36ebnchdj9De6qtHO5HVMq5b0VEAqlq/l9UjY5Bxkg+ FApqRMFSLBTqYDd7IuKdkmq0CLW8rY4iSiwSzowJxkBkFHBVY875ksiqpJxaNFST2YXM nB/8WNIu+H/ICcKyJawx9/ZKL88ecvlRz/eGpDpDsqevaasvAdAXooRKCIctj6taQeD9 Xw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 37c6tg60bw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Mar 2021 11:27:28 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 12JFFq2s093997; Fri, 19 Mar 2021 11:27:28 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 37c6tg60b0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Mar 2021 11:27:28 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12JFMuDN013334; Fri, 19 Mar 2021 15:27:26 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 37crcrgac1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Mar 2021 15:27:26 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12JFR6EC36831524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Mar 2021 15:27:06 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 66030A4054; Fri, 19 Mar 2021 15:27:23 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9EFFBA405B; Fri, 19 Mar 2021 15:27:21 +0000 (GMT) Received: from li-e979b1cc-23ba-11b2-a85c-dfd230f6cf82 (unknown [9.171.16.62]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with SMTP; Fri, 19 Mar 2021 15:27:21 +0000 (GMT) Date: Fri, 19 Mar 2021 16:27:19 +0100 From: Halil Pasic To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [RFC PATCH 1/2] modules: introduce target specific modules Message-ID: <20210319162719.5779e251.pasic@linux.ibm.com> In-Reply-To: <9b103263-c3fa-79b9-5ff7-349bfbf60d78@redhat.com> References: <20210316122648.3372459-1-pasic@linux.ibm.com> <20210316122648.3372459-2-pasic@linux.ibm.com> <9b103263-c3fa-79b9-5ff7-349bfbf60d78@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-19_06:2021-03-19, 2021-03-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103190107 Received-SPF: pass client-ip=148.163.158.5; envelope-from=pasic@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Fiuczynski , David Hildenbrand , Alexey Kardashevskiy , Bin Meng , qemu-devel@nongnu.org, Alistair Francis , Gerd Hoffmann , Anup Patel , Bruce Rogers , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Laurent Vivier , Thomas Huth , Palmer Dabbelt , Eduardo Habkost , Richard Henderson , qemu-s390x@nongnu.org, Stefan Hajnoczi , Alejandro Jimenez , Alex =?UTF-8?B?QmVubsOpZQ==?= , David Gibson , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , Cornelia Huck , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 18 Mar 2021 12:36:48 +0100 Philippe Mathieu-Daudé wrote: > > diff --git a/roms/SLOF b/roms/SLOF > > index 33a7322de1..e18ddad851 160000 > > --- a/roms/SLOF > > +++ b/roms/SLOF > > @@ -1 +1 @@ > > -Subproject commit 33a7322de13e9dca4b38851a345a58d37e7a441d > > +Subproject commit e18ddad8516ff2cfe36ec130200318f7251aa78c > > diff --git a/roms/opensbi b/roms/opensbi > > index 234ed8e427..a98258d0b5 160000 > > --- a/roms/opensbi > > +++ b/roms/opensbi > > @@ -1 +1 @@ > > -Subproject commit 234ed8e427f4d92903123199f6590d144e0d9351 > > +Subproject commit a98258d0b537a295f517bbc8d813007336731fa9 > > While your patch deals with "target modules", the 2 submodule > changes are unrelated, right? Hi Philippe! Not only unrelated but also unintentional. Seems I was not careful enough with "git add -u". Should we decide to go in this direction (symlinks) I will make sure to drop these changes next time. Regards, Halil