qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Rolnik <mrolnik@gmail.com>
To: qemu-devel@nongnu.org
Cc: Michael Rolnik <mrolnik@gmail.com>, dgilbert@redhat.com, rth@twiddle.net
Subject: [PATCH 1/1] Set TARGET_PAGE_BITS to be 10 instead of 8 bits
Date: Sun, 21 Mar 2021 00:09:49 +0200	[thread overview]
Message-ID: <20210320220949.40965-2-mrolnik@gmail.com> (raw)
In-Reply-To: <20210320220949.40965-1-mrolnik@gmail.com>

Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
---
 target/avr/cpu-param.h | 8 +-------
 target/avr/helper.c    | 2 --
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/target/avr/cpu-param.h b/target/avr/cpu-param.h
index 7ef4e7c679..9765a9d0db 100644
--- a/target/avr/cpu-param.h
+++ b/target/avr/cpu-param.h
@@ -22,13 +22,7 @@
 #define AVR_CPU_PARAM_H
 
 #define TARGET_LONG_BITS 32
-/*
- * TARGET_PAGE_BITS cannot be more than 8 bits because
- * 1.  all IO registers occupy [0x0000 .. 0x00ff] address range, and they
- *     should be implemented as a device and not memory
- * 2.  SRAM starts at the address 0x0100
- */
-#define TARGET_PAGE_BITS 8
+#define TARGET_PAGE_BITS 10
 #define TARGET_PHYS_ADDR_SPACE_BITS 24
 #define TARGET_VIRT_ADDR_SPACE_BITS 24
 #define NB_MMU_MODES 2
diff --git a/target/avr/helper.c b/target/avr/helper.c
index 35e1019594..da658afed3 100644
--- a/target/avr/helper.c
+++ b/target/avr/helper.c
@@ -111,8 +111,6 @@ bool avr_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
     MemTxAttrs attrs = {};
     uint32_t paddr;
 
-    address &= TARGET_PAGE_MASK;
-
     if (mmu_idx == MMU_CODE_IDX) {
         /* access to code in flash */
         paddr = OFFSET_CODE + address;
-- 
2.25.1



  reply	other threads:[~2021-03-20 22:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 22:09 [PATCH 0/1] Set AVR TARGET_PAGE_BITS to be 10 instead of 8 Michael Rolnik
2021-03-20 22:09 ` Michael Rolnik [this message]
2021-03-23 12:46   ` [PATCH 1/1] Set TARGET_PAGE_BITS to be 10 instead of 8 bits Dr. David Alan Gilbert
2021-03-23 20:11     ` Michael Rolnik
2021-03-23 20:28       ` Michael Rolnik
2021-04-10 17:24         ` Michael Rolnik
2021-04-11 15:12           ` Richard Henderson
2021-04-12  9:07             ` Peter Maydell
2021-04-27 17:52               ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210320220949.40965-2-mrolnik@gmail.com \
    --to=mrolnik@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).