From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 4/5] contrib: ivshmem client and server build fix for SunOS.
Date: Sun, 21 Mar 2021 18:18:32 +0100 [thread overview]
Message-ID: <20210321171833.20736-5-thuth@redhat.com> (raw)
In-Reply-To: <20210321171833.20736-1-thuth@redhat.com>
From: David CARLIER <devnexen@gmail.com>
sun is a macro on these systems, thus renaming the variables on the
client and server.
Signed-off-by: David Carlier <devnexen@gmail.com>
Message-Id: <CA+XhMqzHPG5ezqY-YxbA+tMoadA3VDFWBX8_LaLC5YsQOMrz+A@mail.gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
contrib/ivshmem-client/ivshmem-client.c | 12 ++++++------
contrib/ivshmem-server/ivshmem-server.c | 12 ++++++------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/contrib/ivshmem-client/ivshmem-client.c b/contrib/ivshmem-client/ivshmem-client.c
index b1274b236a..182c79d27c 100644
--- a/contrib/ivshmem-client/ivshmem-client.c
+++ b/contrib/ivshmem-client/ivshmem-client.c
@@ -178,7 +178,7 @@ ivshmem_client_init(IvshmemClient *client, const char *unix_sock_path,
int
ivshmem_client_connect(IvshmemClient *client)
{
- struct sockaddr_un sun;
+ struct sockaddr_un s_un;
int fd, ret;
int64_t tmp;
@@ -192,16 +192,16 @@ ivshmem_client_connect(IvshmemClient *client)
return -1;
}
- sun.sun_family = AF_UNIX;
- ret = snprintf(sun.sun_path, sizeof(sun.sun_path), "%s",
+ s_un.sun_family = AF_UNIX;
+ ret = snprintf(s_un.sun_path, sizeof(s_un.sun_path), "%s",
client->unix_sock_path);
- if (ret < 0 || ret >= sizeof(sun.sun_path)) {
+ if (ret < 0 || ret >= sizeof(s_un.sun_path)) {
IVSHMEM_CLIENT_DEBUG(client, "could not copy unix socket path\n");
goto err_close;
}
- if (connect(client->sock_fd, (struct sockaddr *)&sun, sizeof(sun)) < 0) {
- IVSHMEM_CLIENT_DEBUG(client, "cannot connect to %s: %s\n", sun.sun_path,
+ if (connect(client->sock_fd, (struct sockaddr *)&s_un, sizeof(s_un)) < 0) {
+ IVSHMEM_CLIENT_DEBUG(client, "cannot connect to %s: %s\n", s_un.sun_path,
strerror(errno));
goto err_close;
}
diff --git a/contrib/ivshmem-server/ivshmem-server.c b/contrib/ivshmem-server/ivshmem-server.c
index 88daee812d..39a6ffdb5d 100644
--- a/contrib/ivshmem-server/ivshmem-server.c
+++ b/contrib/ivshmem-server/ivshmem-server.c
@@ -288,7 +288,7 @@ ivshmem_server_init(IvshmemServer *server, const char *unix_sock_path,
int
ivshmem_server_start(IvshmemServer *server)
{
- struct sockaddr_un sun;
+ struct sockaddr_un s_un;
int shm_fd, sock_fd, ret;
/* open shm file */
@@ -327,15 +327,15 @@ ivshmem_server_start(IvshmemServer *server)
goto err_close_shm;
}
- sun.sun_family = AF_UNIX;
- ret = snprintf(sun.sun_path, sizeof(sun.sun_path), "%s",
+ s_un.sun_family = AF_UNIX;
+ ret = snprintf(s_un.sun_path, sizeof(s_un.sun_path), "%s",
server->unix_sock_path);
- if (ret < 0 || ret >= sizeof(sun.sun_path)) {
+ if (ret < 0 || ret >= sizeof(s_un.sun_path)) {
IVSHMEM_SERVER_DEBUG(server, "could not copy unix socket path\n");
goto err_close_sock;
}
- if (bind(sock_fd, (struct sockaddr *)&sun, sizeof(sun)) < 0) {
- IVSHMEM_SERVER_DEBUG(server, "cannot connect to %s: %s\n", sun.sun_path,
+ if (bind(sock_fd, (struct sockaddr *)&s_un, sizeof(s_un)) < 0) {
+ IVSHMEM_SERVER_DEBUG(server, "cannot connect to %s: %s\n", s_un.sun_path,
strerror(errno));
goto err_close_sock;
}
--
2.27.0
next prev parent reply other threads:[~2021-03-21 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 17:18 [PULL 0/5] Unit test fixes + misc OS patches Thomas Huth
2021-03-21 17:18 ` [PULL 1/5] docs/devel/testing.rst: Fix references to unit tests Thomas Huth
2021-03-21 17:18 ` [PULL 2/5] tests/unit/test-block-iothread: fix maybe-uninitialized error on GCC 11 Thomas Huth
2021-03-21 17:18 ` [PULL 3/5] configure: fix for SunOS based systems Thomas Huth
2021-03-21 17:18 ` Thomas Huth [this message]
2021-03-21 17:18 ` [PULL 5/5] FreeBSD: Upgrade to 12.2 release Thomas Huth
2021-03-22 11:24 ` [PULL 0/5] Unit test fixes + misc OS patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321171833.20736-5-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).