From: Claudio Fontana <cfontana@suse.de>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Claudio Fontana <cfontana@suse.de>,
qemu-devel@nongnu.org
Subject: [PATCH v28 21/23] accel: move call to accel_init_interfaces
Date: Mon, 22 Mar 2021 14:27:58 +0100 [thread overview]
Message-ID: <20210322132800.7470-23-cfontana@suse.de> (raw)
In-Reply-To: <20210322132800.7470-1-cfontana@suse.de>
move the call for sysemu specifically in machine_run_board_init,
mirror the calling sequence for user mode too.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Claudio Fontana <cfontana@suse.de>
---
bsd-user/main.c | 2 +-
hw/core/machine.c | 1 +
linux-user/main.c | 2 +-
softmmu/vl.c | 1 -
4 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index 798aba512c..ae0fd75aa1 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -914,8 +914,8 @@ int main(int argc, char **argv)
{
AccelClass *ac = ACCEL_GET_CLASS(current_accel());
- ac->init_machine(NULL);
accel_init_interfaces(ac);
+ ac->init_machine(NULL);
}
cpu = cpu_create(cpu_type);
env = cpu->env_ptr;
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 257a664ea2..678558b9ac 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1216,6 +1216,7 @@ void machine_run_board_init(MachineState *machine)
"on", false);
}
+ accel_init_interfaces(ACCEL_GET_CLASS(machine->accelerator));
machine_class->init(machine);
phase_advance(PHASE_MACHINE_INITIALIZED);
}
diff --git a/linux-user/main.c b/linux-user/main.c
index f956afccab..3ad442b82e 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -730,8 +730,8 @@ int main(int argc, char **argv, char **envp)
{
AccelClass *ac = ACCEL_GET_CLASS(current_accel());
- ac->init_machine(NULL);
accel_init_interfaces(ac);
+ ac->init_machine(NULL);
}
cpu = cpu_create(cpu_type);
env = cpu->env_ptr;
diff --git a/softmmu/vl.c b/softmmu/vl.c
index aadb526138..584d100205 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -3596,7 +3596,6 @@ void qemu_init(int argc, char **argv, char **envp)
current_machine->cpu_type = parse_cpu_option(cpu_option);
}
/* NB: for machine none cpu_type could STILL be NULL here! */
- accel_init_interfaces(ACCEL_GET_CLASS(current_machine->accelerator));
qemu_resolve_machine_memdev();
parse_numa_opts(current_machine);
--
2.26.2
next prev parent reply other threads:[~2021-03-22 13:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 13:27 [PATCH v28 00/23] i386 cleanup PART 2 Claudio Fontana
2021-03-22 13:27 ` [RFC] accel: add cpu_reset Claudio Fontana
2021-03-22 13:31 ` Paolo Bonzini
2021-03-22 13:35 ` Claudio Fontana
2021-03-22 13:45 ` Paolo Bonzini
2021-03-22 13:51 ` Claudio Fontana
2021-03-23 7:55 ` Paolo Bonzini
2021-03-22 13:42 ` Philippe Mathieu-Daudé
2021-03-22 13:54 ` Claudio Fontana
2021-03-23 8:43 ` Philippe Mathieu-Daudé
2021-03-22 13:27 ` [PATCH v28 01/23] target/i386: Rename helper_fldt, helper_fstt Claudio Fontana
2021-03-22 15:58 ` Alex Bennée
2021-03-22 13:27 ` [PATCH v28 02/23] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor Claudio Fontana
2021-03-22 16:14 ` Alex Bennée
2021-03-22 13:27 ` [PATCH v28 03/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 04/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 05/23] accel: introduce new accessor functions Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 06/23] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 07/23] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 08/23] meson: add target_user_arch Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 09/23] i386: split off sysemu-only functionality in tcg-cpu Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 10/23] i386: split smm helper (sysemu) Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 11/23] i386: split tcg excp_helper into sysemu and user parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 12/23] i386: move TCG bpt_helper into sysemu/ Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 13/23] i386: split misc helper user stubs and sysemu part Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 14/23] i386: separate fpu_helper sysemu-only parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 15/23] i386: split svm_helper into sysemu and stub-only user Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 16/23] i386: split seg_helper into user-only and sysemu parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 17/23] i386: split off sysemu part of cpu.c Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 18/23] target/i386: gdbstub: introduce aux functions to read/write CS64 regs Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 19/23] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 20/23] i386: make cpu_load_efer sysemu-only Claudio Fontana
2021-03-22 13:27 ` Claudio Fontana [this message]
2021-03-22 13:27 ` [PATCH v28 22/23] accel: add init_accel_cpu for adapting accel behavior to CPU type Claudio Fontana
2021-03-22 13:28 ` [RFC v28 23/23] XXX RFC accel: add cpu_reset Claudio Fontana
2021-03-22 16:41 ` [PATCH v28 00/23] i386 cleanup PART 2 Paolo Bonzini
2021-04-08 13:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322132800.7470-23-cfontana@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).