From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com, michael.roth@amd.com, marcandre.lureau@redhat.com
Subject: [PATCH 00/28] qapi: Enforce naming rules
Date: Tue, 23 Mar 2021 10:39:57 +0100 [thread overview]
Message-ID: <20210323094025.3569441-1-armbru@redhat.com> (raw)
This will save us pointless review - fix up cycles. We should've done
it long ago.
The whole series could be considered bug fixes. Not particularly
urgent ones, though. Options:
* Take them all.
* Take PATCH 01-07 now, queue the rest for 6.1.
* Queue all for 6.1.
Let me know your preferences.
Markus Armbruster (28):
qapi/pragma: Tidy up after removal of deprecated commands
tests/qapi-schema: Drop redundant flat-union-inline test
tests/qapi-schema: Rework comments on longhand member definitions
tests/qapi-schema: Belatedly update comment on alternate clash
tests/qapi-schema: Drop TODO comment on simple unions
tests/qapi-schema: Tweak to demonstrate buggy member name check
qapi: Fix to reject optional members with reserved names
qapi: Support flat unions tag values with leading digit
qapi: Lift enum-specific code out of check_name_str()
qapi: Rework name checking in preparation of stricter checking
qapi: Move uppercase rejection to check_name_lower()
qapi: Consistently permit any case in downstream prefixes
qapi: Enforce event naming rules
qapi: Enforce type naming rules
tests/qapi-schema: Rename redefined-builtin to redefined-predefined
qapi: Factor out QAPISchemaParser._check_pragma_list_of_str()
tests/qapi-schema: Rename pragma-*-crap to pragma-value-not-*
tests/qapi-schema: Rename returns-whitelist to returns-bad-type
qapi: Rename pragma *-whitelist to *-exceptions
qapi/pragma: Streamline comments on member-name-exceptions
tests-qmp-cmds: Drop unused and incorrect qmp_TestIfCmd()
qapi: Prepare for rejecting underscore in command and member names
qapi: Enforce feature naming rules
qapi: Enforce command naming rules
tests/qapi-schema: Switch member name clash test to struct
qapi: Enforce struct member naming rules
qapi: Enforce enum member naming rules
qapi: Enforce union and alternate branch naming rules
docs/devel/qapi-code-gen.txt | 28 +++---
qapi/pragma.json | 65 ++++++++++---
qga/qapi-schema.json | 6 +-
tests/unit/test-qmp-cmds.c | 17 +---
tests/unit/test-qmp-event.c | 6 +-
scripts/qapi/common.py | 8 +-
scripts/qapi/expr.py | 94 ++++++++++++-------
scripts/qapi/parser.py | 30 +++---
scripts/qapi/schema.py | 2 +-
scripts/qapi/source.py | 10 +-
tests/qapi-schema/alternate-clash.err | 2 +-
tests/qapi-schema/alternate-clash.json | 9 +-
tests/qapi-schema/args-member-case.err | 2 +-
tests/qapi-schema/args-name-clash.err | 2 -
tests/qapi-schema/args-name-clash.json | 4 -
tests/qapi-schema/doc-bad-union-member.json | 4 +-
tests/qapi-schema/doc-good.json | 4 +-
tests/qapi-schema/doc-good.out | 4 +-
tests/qapi-schema/doc-good.txt | 2 +-
tests/qapi-schema/doc-invalid-return.json | 4 +-
tests/qapi-schema/double-type.err | 2 +-
tests/qapi-schema/double-type.json | 2 +-
tests/qapi-schema/enum-clash-member.err | 2 +-
tests/qapi-schema/enum-clash-member.json | 1 +
tests/qapi-schema/enum-member-case.err | 2 +-
tests/qapi-schema/enum-member-case.json | 2 +-
tests/qapi-schema/event-case.err | 2 +
tests/qapi-schema/event-case.json | 2 -
tests/qapi-schema/event-case.out | 14 ---
.../qapi-schema/event-member-invalid-dict.err | 2 +-
.../event-member-invalid-dict.json | 2 +
.../qapi-schema/features-deprecated-type.err | 2 +-
.../qapi-schema/features-deprecated-type.json | 2 +-
.../flat-union-inline-invalid-dict.json | 4 +-
tests/qapi-schema/flat-union-inline.err | 2 -
tests/qapi-schema/flat-union-inline.json | 11 ---
tests/qapi-schema/flat-union-no-base.err | 2 +-
tests/qapi-schema/flat-union-no-base.json | 1 -
tests/qapi-schema/meson.build | 14 +--
.../nested-struct-data-invalid-dict.err | 2 +-
.../nested-struct-data-invalid-dict.json | 3 +-
tests/qapi-schema/nested-struct-data.json | 2 +-
.../qapi-schema/pragma-doc-required-crap.err | 1 -
.../pragma-name-case-whitelist-crap.err | 1 -
.../pragma-name-case-whitelist-crap.json | 3 -
.../pragma-returns-whitelist-crap.err | 1 -
.../pragma-returns-whitelist-crap.json | 3 -
tests/qapi-schema/pragma-value-not-bool.err | 1 +
...d-crap.json => pragma-value-not-bool.json} | 2 +-
...me-clash.out => pragma-value-not-bool.out} | 0
.../pragma-value-not-list-of-str.err | 1 +
.../pragma-value-not-list-of-str.json | 3 +
...e.out => pragma-value-not-list-of-str.out} | 0
tests/qapi-schema/pragma-value-not-list.err | 1 +
tests/qapi-schema/pragma-value-not-list.json | 2 +
...red-crap.out => pragma-value-not-list.out} | 0
tests/qapi-schema/qapi-schema-test.json | 35 ++++---
tests/qapi-schema/qapi-schema-test.out | 42 ++++-----
tests/qapi-schema/redefined-builtin.err | 2 -
tests/qapi-schema/redefined-builtin.json | 2 -
tests/qapi-schema/redefined-predefined.err | 2 +
tests/qapi-schema/redefined-predefined.json | 2 +
...list-crap.out => redefined-predefined.out} | 0
tests/qapi-schema/redefined-type.err | 6 +-
tests/qapi-schema/redefined-type.json | 4 +-
tests/qapi-schema/reserved-member-u.err | 2 +-
tests/qapi-schema/reserved-member-u.json | 2 +-
tests/qapi-schema/returns-bad-type.err | 2 +
...s-whitelist.json => returns-bad-type.json} | 2 +-
...hitelist-crap.out => returns-bad-type.out} | 0
tests/qapi-schema/returns-whitelist.err | 2 -
tests/qapi-schema/struct-data-invalid.err | 2 +-
tests/qapi-schema/struct-data-invalid.json | 2 +-
.../struct-member-invalid-dict.err | 4 +-
.../struct-member-invalid-dict.json | 5 +-
tests/qapi-schema/struct-member-invalid.err | 2 +-
tests/qapi-schema/struct-member-invalid.json | 2 +-
.../qapi-schema/struct-member-name-clash.err | 2 +
.../qapi-schema/struct-member-name-clash.json | 5 +
...iltin.out => struct-member-name-clash.out} | 0
tests/qapi-schema/type-case.err | 2 +
tests/qapi-schema/type-case.json | 2 +
.../{returns-whitelist.out => type-case.out} | 0
tests/qapi-schema/union-branch-case.err | 2 +-
tests/qapi-schema/union-clash-branches.err | 2 +-
tests/qapi-schema/union-clash-branches.json | 6 +-
tests/qapi-schema/unknown-expr-key.err | 2 +-
tests/qapi-schema/unknown-expr-key.json | 2 +-
88 files changed, 306 insertions(+), 241 deletions(-)
delete mode 100644 tests/qapi-schema/args-name-clash.err
delete mode 100644 tests/qapi-schema/args-name-clash.json
delete mode 100644 tests/qapi-schema/flat-union-inline.err
delete mode 100644 tests/qapi-schema/flat-union-inline.json
delete mode 100644 tests/qapi-schema/pragma-doc-required-crap.err
delete mode 100644 tests/qapi-schema/pragma-name-case-whitelist-crap.err
delete mode 100644 tests/qapi-schema/pragma-name-case-whitelist-crap.json
delete mode 100644 tests/qapi-schema/pragma-returns-whitelist-crap.err
delete mode 100644 tests/qapi-schema/pragma-returns-whitelist-crap.json
create mode 100644 tests/qapi-schema/pragma-value-not-bool.err
rename tests/qapi-schema/{pragma-doc-required-crap.json => pragma-value-not-bool.json} (55%)
rename tests/qapi-schema/{args-name-clash.out => pragma-value-not-bool.out} (100%)
create mode 100644 tests/qapi-schema/pragma-value-not-list-of-str.err
create mode 100644 tests/qapi-schema/pragma-value-not-list-of-str.json
rename tests/qapi-schema/{flat-union-inline.out => pragma-value-not-list-of-str.out} (100%)
create mode 100644 tests/qapi-schema/pragma-value-not-list.err
create mode 100644 tests/qapi-schema/pragma-value-not-list.json
rename tests/qapi-schema/{pragma-doc-required-crap.out => pragma-value-not-list.out} (100%)
delete mode 100644 tests/qapi-schema/redefined-builtin.err
delete mode 100644 tests/qapi-schema/redefined-builtin.json
create mode 100644 tests/qapi-schema/redefined-predefined.err
create mode 100644 tests/qapi-schema/redefined-predefined.json
rename tests/qapi-schema/{pragma-name-case-whitelist-crap.out => redefined-predefined.out} (100%)
create mode 100644 tests/qapi-schema/returns-bad-type.err
rename tests/qapi-schema/{returns-whitelist.json => returns-bad-type.json} (91%)
rename tests/qapi-schema/{pragma-returns-whitelist-crap.out => returns-bad-type.out} (100%)
delete mode 100644 tests/qapi-schema/returns-whitelist.err
create mode 100644 tests/qapi-schema/struct-member-name-clash.err
create mode 100644 tests/qapi-schema/struct-member-name-clash.json
rename tests/qapi-schema/{redefined-builtin.out => struct-member-name-clash.out} (100%)
create mode 100644 tests/qapi-schema/type-case.err
create mode 100644 tests/qapi-schema/type-case.json
rename tests/qapi-schema/{returns-whitelist.out => type-case.out} (100%)
--
2.26.3
next reply other threads:[~2021-03-23 9:41 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 9:39 Markus Armbruster [this message]
2021-03-23 9:39 ` [PATCH 01/28] qapi/pragma: Tidy up after removal of deprecated commands Markus Armbruster
2021-03-23 12:50 ` John Snow
2021-03-23 9:39 ` [PATCH 02/28] tests/qapi-schema: Drop redundant flat-union-inline test Markus Armbruster
2021-03-23 12:54 ` John Snow
2021-03-23 9:40 ` [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions Markus Armbruster
2021-03-23 13:00 ` John Snow
2021-03-23 13:58 ` Eric Blake
2021-03-23 14:25 ` John Snow
2021-03-23 13:59 ` Eric Blake
2021-03-23 14:27 ` John Snow
2021-03-23 9:40 ` [PATCH 04/28] tests/qapi-schema: Belatedly update comment on alternate clash Markus Armbruster
2021-03-23 13:12 ` John Snow
2021-03-23 9:40 ` [PATCH 05/28] tests/qapi-schema: Drop TODO comment on simple unions Markus Armbruster
2021-03-23 13:16 ` John Snow
2021-03-23 9:40 ` [PATCH 06/28] tests/qapi-schema: Tweak to demonstrate buggy member name check Markus Armbruster
2021-03-23 13:20 ` John Snow
2021-03-23 15:44 ` Markus Armbruster
2021-03-23 17:09 ` John Snow
2021-03-23 20:42 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 07/28] qapi: Fix to reject optional members with reserved names Markus Armbruster
2021-03-23 13:27 ` John Snow
2021-03-23 15:50 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 08/28] qapi: Support flat unions tag values with leading digit Markus Armbruster
2021-03-23 14:11 ` Eric Blake
2021-03-23 14:49 ` John Snow
2021-03-23 16:18 ` Markus Armbruster
2021-03-23 21:07 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str() Markus Armbruster
2021-03-23 14:13 ` Eric Blake
2021-03-23 21:44 ` John Snow
2021-03-23 22:11 ` John Snow
2021-03-24 5:55 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking Markus Armbruster
2021-03-23 14:20 ` Eric Blake
2021-03-23 14:30 ` John Snow
2021-03-23 14:40 ` Eric Blake
2021-03-23 16:25 ` Markus Armbruster
2021-03-23 21:14 ` Markus Armbruster
2021-03-23 22:15 ` John Snow
2021-03-24 5:57 ` Markus Armbruster
2021-03-24 20:11 ` John Snow
2021-03-25 6:18 ` Markus Armbruster
2021-03-25 17:48 ` John Snow
2021-03-26 5:25 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 11/28] qapi: Move uppercase rejection to check_name_lower() Markus Armbruster
2021-03-23 14:29 ` Eric Blake
2021-03-23 22:21 ` John Snow
2021-03-23 9:40 ` [PATCH 12/28] qapi: Consistently permit any case in downstream prefixes Markus Armbruster
2021-03-23 14:30 ` Eric Blake
2021-03-23 22:26 ` John Snow
2021-03-23 9:40 ` [PATCH 13/28] qapi: Enforce event naming rules Markus Armbruster
2021-03-23 14:32 ` Eric Blake
2021-03-23 22:31 ` John Snow
2021-03-24 6:22 ` Markus Armbruster
2021-03-24 20:07 ` John Snow
2021-03-25 6:22 ` Markus Armbruster
2021-03-25 17:50 ` John Snow
2021-03-23 9:40 ` [PATCH 14/28] qapi: Enforce type " Markus Armbruster
2021-03-23 14:50 ` Eric Blake
2021-03-23 16:27 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 15/28] tests/qapi-schema: Rename redefined-builtin to redefined-predefined Markus Armbruster
2021-03-23 14:55 ` Eric Blake
2021-03-23 9:40 ` [PATCH 16/28] qapi: Factor out QAPISchemaParser._check_pragma_list_of_str() Markus Armbruster
2021-03-23 15:01 ` Eric Blake
2021-03-23 9:40 ` [PATCH 17/28] tests/qapi-schema: Rename pragma-*-crap to pragma-value-not-* Markus Armbruster
2021-03-23 15:02 ` Eric Blake
2021-03-23 9:40 ` [PATCH 18/28] tests/qapi-schema: Rename returns-whitelist to returns-bad-type Markus Armbruster
2021-03-23 15:06 ` Eric Blake
2021-03-23 9:40 ` [PATCH 19/28] qapi: Rename pragma *-whitelist to *-exceptions Markus Armbruster
2021-03-23 15:09 ` Eric Blake
2021-03-23 16:35 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 20/28] qapi/pragma: Streamline comments on member-name-exceptions Markus Armbruster
2021-03-23 15:10 ` Eric Blake
2021-03-23 9:40 ` [PATCH 21/28] tests-qmp-cmds: Drop unused and incorrect qmp_TestIfCmd() Markus Armbruster
2021-03-23 15:11 ` Eric Blake
2021-03-23 9:40 ` [PATCH 22/28] qapi: Prepare for rejecting underscore in command and member names Markus Armbruster
2021-03-23 15:15 ` Eric Blake
2021-03-23 9:40 ` [PATCH 23/28] qapi: Enforce feature naming rules Markus Armbruster
2021-03-23 15:16 ` Eric Blake
2021-03-23 9:40 ` [PATCH 24/28] qapi: Enforce command " Markus Armbruster
2021-03-23 15:23 ` Eric Blake
2021-03-23 21:19 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 25/28] tests/qapi-schema: Switch member name clash test to struct Markus Armbruster
2021-03-23 15:42 ` Eric Blake
2021-03-23 9:40 ` [PATCH 26/28] qapi: Enforce struct member naming rules Markus Armbruster
2021-03-23 15:46 ` Eric Blake
2021-03-23 21:23 ` Markus Armbruster
2021-03-23 9:40 ` [PATCH 27/28] qapi: Enforce enum " Markus Armbruster
2021-03-23 15:47 ` Eric Blake
2021-03-23 9:40 ` [PATCH 28/28] qapi: Enforce union and alternate branch " Markus Armbruster
2021-03-23 16:05 ` Eric Blake
2021-03-23 21:24 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323094025.3569441-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).