From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC528C433C1 for ; Tue, 23 Mar 2021 13:09:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43C91619B8 for ; Tue, 23 Mar 2021 13:09:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43C91619B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOgnF-000138-0h for qemu-devel@archiver.kernel.org; Tue, 23 Mar 2021 09:09:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOgjm-0005TW-IW; Tue, 23 Mar 2021 09:06:22 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:41949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOgjk-0002LE-Sh; Tue, 23 Mar 2021 09:06:22 -0400 Received: by mail-wr1-x435.google.com with SMTP id b9so20702749wrt.8; Tue, 23 Mar 2021 06:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0M8wW87BuDH+rmu9cePgKen5O5CaaJxYZ5OM4Z4+XQc=; b=EcBFcbtOSqvotXUwc8ZCZVIWS2nNdlxHeKDbQxruMsrHZvxlchZXXxKRARK8ZtXsMC ZTPUwJ55ZnRaSRJiSRKBVARDwE4c6njR2YZSlWZtIHiQjuRq4K29OzzkwyTmMYc6E4QG ZAHSXfL8O5h9kDfXplmduNhiIGefA/hwmhaxA4Bt18OR2Z8vOfvxE3xcU9g0F76fw0h+ hcKOwdKqWLwXbCWHiD8oXnLQYQs5rcARRcuDGuU37TxStayOnT4iTLHZFd3H3FUj5ZJd 6XggpD6anDH8E62L86ytcfy+ee5Vyphq0WBcZ6F1bso0HLNRkq+PUx4Kh3bl6th00NQV t0NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0M8wW87BuDH+rmu9cePgKen5O5CaaJxYZ5OM4Z4+XQc=; b=KdZWO+OS2g3UN8xjLnDqs0ch5R8yx/P2rerqaSRDpNb72tXynzQ+u4xZ1uKbump1OU qSfAeIrZGbxM+FeNdT+09IlvA/eOro7hwhLpk44sVQfim8f2VoAIzAIVkslxSE7/b/nM hXN20eLHK6zmf0CP66+uT+x4/rUda73rPCVljn9MxSRXOwzLJZgvXNTD/jlcrt8U+APp +mGK2er2iR6ghVw/zqCywoIly+swjYvTeIWAmnO8a8Cjwe72cqewIXyVGlK0tlvbcs4G 1Vz+X2BTuEMXC9JPCdk/O1Rkbi9Y9QUzfUfiC+4KHLDZAa9sv5e5tXuJygnz4QxsGQnC ySJA== X-Gm-Message-State: AOAM532tFasPvU55/oxeqQ7U3v+UE0TbIga4ZII2C2s6Pq1ApVOH/ivD TlY/Gwnnl4ZeA59AtadYXa8TXCQMtuM= X-Google-Smtp-Source: ABdhPJxKY6wx3tDNPnlFbxzT9zb2/sxe8Ug7kX0dy5Pr7yLX+HS2Ke/D4Z3z6cLqxnFsCqdt2HFp0A== X-Received: by 2002:a5d:42d2:: with SMTP id t18mr3935711wrr.258.1616504779187; Tue, 23 Mar 2021 06:06:19 -0700 (PDT) Received: from avogadro.lan ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id i8sm2507590wmi.6.2021.03.23.06.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 06:06:18 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 3/4] qemu-iotests: let "check" spawn an arbitrary test command Date: Tue, 23 Mar 2021 14:06:13 +0100 Message-Id: <20210323130614.146399-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210323130614.146399-1-pbonzini@redhat.com> References: <20210323130614.146399-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=paolo.bonzini@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eesposit@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice. This can be for example a Python unit test with arguments to only run a specific subtest. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/check | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index d1c87ceaf1..aab25dac6a 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -19,6 +19,7 @@ import os import sys import argparse +import shutil from findtests import TestFinder from testenv import TestEnv from testrunner import TestRunner @@ -100,8 +101,8 @@ def make_argparser() -> argparse.ArgumentParser: 'one to TEST (not inclusive). This may be used to ' 'rerun failed ./check command, starting from the ' 'middle of the process.') - g_sel.add_argument('tests', metavar='TEST_FILES', nargs='*', - help='tests to run') + g_sel.add_argument('tests', nargs=argparse.REMAINDER, + help='tests to run, or "--" followed by a command') return p @@ -114,6 +115,17 @@ if __name__ == '__main__': imgopts=args.imgopts, misalign=args.misalign, debug=args.debug, valgrind=args.valgrind) + if args.tests[0] == '--': + del args.tests[0] + cmd = args.tests + env.print_env() + exec_path = shutil.which(cmd[0]) + if exec_path is None: + sys.exit('command not found: ' + cmd[0]) + cmd[0] = exec_path + full_env = env.prepare_subprocess(cmd) + os.execve(cmd[0], cmd, full_env) + testfinder = TestFinder(test_dir=env.source_iotests) groups = args.groups.split(',') if args.groups else None -- 2.30.1