From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>
Subject: [PATCH v2 2/3] hw/display/bcm2835_fb: Use bcm2835_fb_reconfigure in bcm2835_fb_reset
Date: Tue, 23 Mar 2021 17:14:42 +0100 [thread overview]
Message-ID: <20210323161443.245636-3-f4bug@amsat.org> (raw)
In-Reply-To: <20210323161443.245636-1-f4bug@amsat.org>
Directly use bcm2835_fb_reconfigure() instead of open coding it.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/display/bcm2835_fb.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
index 3e63d58e0b2..a9c2e57d1c6 100644
--- a/hw/display/bcm2835_fb.c
+++ b/hw/display/bcm2835_fb.c
@@ -396,11 +396,7 @@ static void bcm2835_fb_reset(DeviceState *dev)
s->pending = false;
- s->config = s->initial_config;
-
- s->invalidate = true;
- qemu_console_resize(s->con, s->initial_config.xres, s->initial_config.yres);
- s->lock = false;
+ bcm2835_fb_reconfigure(s, &s->initial_config);
}
static void bcm2835_fb_realize(DeviceState *dev, Error **errp)
--
2.26.2
next prev parent reply other threads:[~2021-03-23 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 16:14 [PATCH v2 0/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Philippe Mathieu-Daudé
2021-03-23 16:14 ` [PATCH v2 1/3] hw/display/bcm2835_fb: Resize console on reset Philippe Mathieu-Daudé
2021-03-26 14:27 ` Peter Maydell
2021-03-26 23:13 ` Philippe Mathieu-Daudé
2021-03-29 5:59 ` Gerd Hoffmann
2021-05-19 18:22 ` Philippe Mathieu-Daudé
2021-03-23 16:14 ` Philippe Mathieu-Daudé [this message]
2021-03-23 16:14 ` [PATCH v2 3/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323161443.245636-3-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).