* [PATCH] hw/isa/piix4: Migrate Reset Control Register
@ 2021-03-24 14:28 Philippe Mathieu-Daudé
2021-03-24 15:38 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-24 14:28 UTC (permalink / raw)
To: qemu-devel
Cc: Hervé Poussineau, Philippe Mathieu-Daudé,
Aurelien Jarno, Dr . David Alan Gilbert
Fixes: 5790b757cfb ("piix4: Add the Reset Control Register")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/isa/piix4.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index a50d97834c7..6eeff4525f8 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -95,10 +95,11 @@ static void piix4_isa_reset(DeviceState *dev)
static const VMStateDescription vmstate_piix4 = {
.name = "PIIX4",
- .version_id = 2,
- .minimum_version_id = 2,
+ .version_id = 3,
+ .minimum_version_id = 3,
.fields = (VMStateField[]) {
VMSTATE_PCI_DEVICE(dev, PIIX4State),
+ VMSTATE_UINT8(rcr, PIIX4State),
VMSTATE_END_OF_LIST()
}
};
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/isa/piix4: Migrate Reset Control Register
2021-03-24 14:28 [PATCH] hw/isa/piix4: Migrate Reset Control Register Philippe Mathieu-Daudé
@ 2021-03-24 15:38 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2021-03-24 15:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Hervé Poussineau, qemu-devel, Aurelien Jarno
* Philippe Mathieu-Daudé (f4bug@amsat.org) wrote:
> Fixes: 5790b757cfb ("piix4: Add the Reset Control Register")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
So if I understand correctly, piix4 is only used on one of the MIPS
machines, so that bumping the version here won't break anyone who
cares about backwards migration; in which case from a migration point of
view:
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/isa/piix4.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
> index a50d97834c7..6eeff4525f8 100644
> --- a/hw/isa/piix4.c
> +++ b/hw/isa/piix4.c
> @@ -95,10 +95,11 @@ static void piix4_isa_reset(DeviceState *dev)
>
> static const VMStateDescription vmstate_piix4 = {
> .name = "PIIX4",
> - .version_id = 2,
> - .minimum_version_id = 2,
> + .version_id = 3,
> + .minimum_version_id = 3,
> .fields = (VMStateField[]) {
> VMSTATE_PCI_DEVICE(dev, PIIX4State),
> + VMSTATE_UINT8(rcr, PIIX4State),
> VMSTATE_END_OF_LIST()
> }
> };
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-24 14:28 [PATCH] hw/isa/piix4: Migrate Reset Control Register Philippe Mathieu-Daudé
2021-03-24 15:38 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).