From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jie Deng <jie.deng@intel.com>
Cc: "Vincent Guittot" <vincent.guittot@linaro.org>,
"Bill Mills" <bill.mills@linaro.org>,
qemu-devel@nongnu.org, "Arnd Bergmann" <arnd.bergmann@linaro.com>,
"Mike Holmes" <mike.holmes@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
stratos-dev@op-lists.linaro.org
Subject: Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver
Date: Thu, 25 Mar 2021 12:06:49 +0530 [thread overview]
Message-ID: <20210325063649.tvsxcxbbxuajl3og@vireshk-i7> (raw)
In-Reply-To: <f2f80985-b452-23e0-1892-2c8eaba4e691@intel.com>
On 25-03-21, 14:17, Jie Deng wrote:
> i2c->adapter_num is set here, but used in vi2c_remove_adapters.
> when you goto out from while {...}, i2c->adapter_num is always 0,
> May be a bug ?
It certainly is, this should fix it:
diff --git a/tools/vhost-user-i2c/main.c b/tools/vhost-user-i2c/main.c
index 071493cbd5c5..65d27ef04d42 100644
--- a/tools/vhost-user-i2c/main.c
+++ b/tools/vhost-user-i2c/main.c
@@ -202,7 +202,7 @@ static void vi2c_remove_adapters(VuI2c *i2c)
VI2cAdapter *adapter;
int32_t i;
- for (i = 0; i < i2c->adapter_num; i++) {
+ for (i = 0; i < MAX_I2C_ADAPTER; i++) {
adapter = i2c->adapter[i];
if (!adapter) {
break;
--
viresh
next prev parent reply other threads:[~2021-03-25 6:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:33 [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend Viresh Kumar
2021-03-24 7:33 ` [PATCH 1/5] hw/virtio: add boilerplate for vhost-user-i2c device Viresh Kumar
2021-03-29 15:13 ` Alex Bennée
2021-03-24 7:33 ` [PATCH 2/5] hw/virtio: add vhost-user-i2c-pci boilerplate Viresh Kumar
2021-03-29 15:19 ` Alex Bennée
2021-03-24 7:33 ` [PATCH 3/5] tools/vhost-user-i2c: Add backend driver Viresh Kumar
2021-03-25 5:09 ` Jie Deng
2021-03-25 5:22 ` Viresh Kumar
2021-03-25 12:22 ` Alex Bennée
2021-03-30 12:49 ` Alex Bennée
2021-03-25 6:17 ` Jie Deng
2021-03-25 6:36 ` Viresh Kumar [this message]
2021-03-25 16:16 ` Arnd Bergmann
2021-03-26 6:01 ` Viresh Kumar
2021-03-26 8:33 ` Arnd Bergmann
2021-03-26 7:14 ` Viresh Kumar
2021-03-26 8:24 ` Arnd Bergmann
2021-03-24 7:33 ` [PATCH 4/5] docs: add a man page for vhost-user-i2c Viresh Kumar
2021-03-24 7:33 ` [PATCH 5/5] MAINTAINERS: Add entry for virtio-i2c Viresh Kumar
2021-03-24 7:42 ` [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend no-reply
2021-03-24 11:05 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325063649.tvsxcxbbxuajl3og@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=arnd.bergmann@linaro.com \
--cc=bill.mills@linaro.org \
--cc=jie.deng@intel.com \
--cc=mike.holmes@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).