From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: eesposit@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: [PATCH v3 5/5] qemu-iotests: fix case of SOCK_DIR already in the environment
Date: Fri, 26 Mar 2021 15:23:59 +0100 [thread overview]
Message-ID: <20210326142359.431127-6-pbonzini@redhat.com> (raw)
In-Reply-To: <20210326142359.431127-1-pbonzini@redhat.com>
Due to a typo, in this case the SOCK_DIR was not being created.
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Tested-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20210323181928.311862-6-pbonzini@redhat.com>
---
tests/qemu-iotests/testenv.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index cd0e39b789..0c3fe75636 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -120,7 +120,7 @@ def init_directories(self) -> None:
try:
self.sock_dir = os.environ['SOCK_DIR']
self.tmp_sock_dir = False
- Path(self.test_dir).mkdir(parents=True, exist_ok=True)
+ Path(self.sock_dir).mkdir(parents=True, exist_ok=True)
except KeyError:
self.sock_dir = tempfile.mkdtemp()
self.tmp_sock_dir = True
--
2.30.1
next prev parent reply other threads:[~2021-03-26 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 14:23 [PATCH v3 0/5] qemu-iotests: quality of life improvements Paolo Bonzini
2021-03-26 14:23 ` [PATCH v3 1/5] qemu-iotests: do not buffer the test output Paolo Bonzini
2021-03-26 14:23 ` [PATCH v3 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts Paolo Bonzini
2021-03-26 14:23 ` [PATCH v3 3/5] qemu-iotests: move command line and environment handling from TestRunner to TestEnv Paolo Bonzini
2021-03-26 14:23 ` [PATCH v3 4/5] qemu-iotests: let "check" spawn an arbitrary test command Paolo Bonzini
2021-03-26 15:05 ` Max Reitz
2021-03-30 10:38 ` Max Reitz
2021-03-30 10:44 ` Max Reitz
2021-03-30 10:57 ` Max Reitz
2021-03-30 11:12 ` Paolo Bonzini
2021-03-26 14:23 ` Paolo Bonzini [this message]
2021-03-30 11:32 ` [PATCH v3 0/5] qemu-iotests: quality of life improvements Max Reitz
2021-03-30 11:44 ` Max Reitz
2021-03-30 11:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326142359.431127-6-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=eesposit@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).