* [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"
@ 2021-03-28 5:47 Thomas Huth
2021-03-29 9:42 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2021-03-28 5:47 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Daniel P. Berrangé, Eduardo Habkost
This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2.
The real code change had already been added by Kevin's commit da0a932bbf
("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated
include statement as a left-over of a rebase.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
qom/object_interfaces.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index c3324b0f86..b17aa57de1 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -17,7 +17,6 @@
#include "qemu/qemu-print.h"
#include "qapi/opts-visitor.h"
#include "qemu/config-file.h"
-#include "qemu/qemu-print.h"
bool user_creatable_complete(UserCreatable *uc, Error **errp)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"
2021-03-28 5:47 [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects" Thomas Huth
@ 2021-03-29 9:42 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-03-29 9:42 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: qemu-trivial, Daniel P. Berrangé, Eduardo Habkost
On 28/03/21 07:47, Thomas Huth wrote:
> This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2.
>
> The real code change had already been added by Kevin's commit da0a932bbf
> ("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated
> include statement as a left-over of a rebase.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qom/object_interfaces.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> index c3324b0f86..b17aa57de1 100644
> --- a/qom/object_interfaces.c
> +++ b/qom/object_interfaces.c
> @@ -17,7 +17,6 @@
> #include "qemu/qemu-print.h"
> #include "qapi/opts-visitor.h"
> #include "qemu/config-file.h"
> -#include "qemu/qemu-print.h"
>
> bool user_creatable_complete(UserCreatable *uc, Error **errp)
> {
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-28 5:47 [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects" Thomas Huth
2021-03-29 9:42 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).