qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Lukas Straub <lukasstraub2@web.de>
Subject: [PULL 06/10] yank: Always link full yank code
Date: Sun, 28 Mar 2021 22:45:29 +0400	[thread overview]
Message-ID: <20210328184533.752840-7-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20210328184533.752840-1-marcandre.lureau@redhat.com>

From: Lukas Straub <lukasstraub2@web.de>

Yank now only depends on util and can be always linked in. Also remove
the stubs as they are not needed anymore.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <997aa12a28c555d8a3b7a363b3bda5c3cf1821ba.1616521341.git.lukasstraub2@web.de>
---
 stubs/yank.c      | 23 -----------------------
 MAINTAINERS       |  1 -
 stubs/meson.build |  1 -
 util/meson.build  |  2 +-
 4 files changed, 1 insertion(+), 26 deletions(-)
 delete mode 100644 stubs/yank.c

diff --git a/stubs/yank.c b/stubs/yank.c
deleted file mode 100644
index 11b24fc057..0000000000
--- a/stubs/yank.c
+++ /dev/null
@@ -1,23 +0,0 @@
-#include "qemu/osdep.h"
-#include "qemu/yank.h"
-
-bool yank_register_instance(const YankInstance *instance, Error **errp)
-{
-    return true;
-}
-
-void yank_unregister_instance(const YankInstance *instance)
-{
-}
-
-void yank_register_function(const YankInstance *instance,
-                            YankFn *func,
-                            void *opaque)
-{
-}
-
-void yank_unregister_function(const YankInstance *instance,
-                              YankFn *func,
-                              void *opaque)
-{
-}
diff --git a/MAINTAINERS b/MAINTAINERS
index 12c28feb35..dcab656e62 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2822,7 +2822,6 @@ Yank feature
 M: Lukas Straub <lukasstraub2@web.de>
 S: Odd fixes
 F: util/yank.c
-F: stubs/yank.c
 F: migration/yank_functions*
 F: include/qemu/yank.h
 F: qapi/yank.json
diff --git a/stubs/meson.build b/stubs/meson.build
index 8a3e804cf0..be6f6d609e 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -46,7 +46,6 @@ stub_ss.add(files('vm-stop.c'))
 stub_ss.add(files('win32-kbd-hook.c'))
 stub_ss.add(files('cpu-synchronize-state.c'))
 if have_block
-  stub_ss.add(files('yank.c'))
   stub_ss.add(files('replay-tools.c'))
 endif
 if have_system
diff --git a/util/meson.build b/util/meson.build
index 984fba965f..510765cde4 100644
--- a/util/meson.build
+++ b/util/meson.build
@@ -43,6 +43,7 @@ util_ss.add(files('stats64.c'))
 util_ss.add(files('systemd.c'))
 util_ss.add(when: 'CONFIG_POSIX', if_true: files('drm.c'))
 util_ss.add(files('guest-random.c'))
+util_ss.add(files('yank.c'))
 
 if have_user
   util_ss.add(files('selfmap.c'))
@@ -51,7 +52,6 @@ endif
 if have_system
   util_ss.add(files('crc-ccitt.c'))
   util_ss.add(when: 'CONFIG_GIO', if_true: [files('dbus.c'), gio])
-  util_ss.add(files('yank.c'))
   util_ss.add(when: 'CONFIG_LINUX', if_true: files('userfaultfd.c'))
 endif
 
-- 
2.29.0



  parent reply	other threads:[~2021-03-28 18:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 18:45 [PULL 00/10] For 6.0 patches marcandre.lureau
2021-03-28 18:45 ` [PULL 01/10] util: fix use-after-free in module_load_one marcandre.lureau
2021-03-28 18:45 ` [PULL 02/10] dbus-vmstate: Increase the size of input stream buffer used during load marcandre.lureau
2021-03-28 18:45 ` [PULL 03/10] sphinx: adopt kernel readthedoc theme marcandre.lureau
2021-03-28 18:45 ` [PULL 04/10] docs: simplify each section title marcandre.lureau
2021-03-28 18:45 ` [PULL 05/10] yank: Remove dependency on qiochannel marcandre.lureau
2021-03-28 18:45 ` marcandre.lureau [this message]
2021-03-28 18:45 ` [PULL 07/10] chardev/char.c: Move object_property_try_add_child out of chardev_new marcandre.lureau
2021-03-28 18:45 ` [PULL 08/10] chardev/char.c: Always pass id to chardev_new marcandre.lureau
2021-03-28 18:45 ` [PULL 09/10] chardev: Fix yank with the chardev-change case marcandre.lureau
2021-03-28 18:45 ` [PULL 10/10] tests: Add tests for " marcandre.lureau
2021-03-28 19:00 ` [PULL 00/10] For 6.0 patches no-reply
2021-03-29 13:53 ` Peter Maydell
2021-03-29 14:16   ` Marc-André Lureau
2021-03-29 15:56     ` Peter Maydell
2021-03-29 16:30       ` Marc-André Lureau
2021-03-29 17:54         ` Peter Maydell
2021-03-30  8:29           ` Marc-André Lureau
2021-03-30 12:11             ` Peter Maydell
2021-03-30 14:36               ` Marc-André Lureau
2021-03-29 16:26     ` Lukas Straub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210328184533.752840-7-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).