From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Edmondson <dme@dme.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
libvir-list@redhat.com, "qemu devel list" <qemu-devel@nongnu.org>,
"Vitaly Cheptsov" <cheptsov@ispras.ru>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: Ways to deal with broken machine types
Date: Tue, 30 Mar 2021 07:53:59 -0400 [thread overview]
Message-ID: <20210330075313-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <m2o8f0q43i.fsf@dme.org>
On Tue, Mar 30, 2021 at 12:21:37PM +0100, David Edmondson wrote:
> > Unfortunately I do not think this is practical :(.
> >
> > All examples of breakage I am aware of, we did not
> > realise some part of interface was part of guest ABI
> > and unsafe to change. We simply would not know to write a
> > test for it.
>
> While agreeing that it would not be possible to cover all aspects of the
> ABI immediately, does that mean that some level of coverage would not be
> useful?
Our testing already warns about ACPI table changes (which is what
happened here). We just verified them manually and thought they are
fine.
--
MST
next prev parent reply other threads:[~2021-03-30 11:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 19:59 [PATCH] i386/acpi: restore device paths for pre-5.1 vms Vitaly Cheptsov
2021-03-01 19:59 ` [PATCH] target/ppc: fix icount support on Book-e vms accessing SPRs Vitaly Cheptsov
2021-03-02 7:05 ` [PATCH] i386/acpi: restore device paths for pre-5.1 vms Thomas Lamprecht
2021-03-02 8:48 ` Igor Mammedov
2021-03-02 10:14 ` Michael S. Tsirkin
2021-03-22 15:43 ` Michael S. Tsirkin
2021-03-22 15:49 ` Vitaly Cheptsov
2021-03-23 14:48 ` Michael S. Tsirkin
2021-03-23 14:55 ` Vitaly Cheptsov
2021-03-23 15:04 ` Thomas Lamprecht
2021-03-23 16:54 ` Ways to deal with broken machine types Igor Mammedov
2021-03-23 17:40 ` Daniel P. Berrangé
2021-03-23 19:40 ` Michael S. Tsirkin
2021-03-30 11:21 ` David Edmondson
2021-03-30 11:53 ` Michael S. Tsirkin [this message]
2021-03-26 0:48 ` Igor Mammedov
2021-03-29 14:46 ` Dr. David Alan Gilbert
2021-03-29 20:32 ` Igor Mammedov
2021-03-23 19:32 ` [PATCH] i386/acpi: restore device paths for pre-5.1 vms Michael S. Tsirkin
2021-03-26 0:12 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330075313-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=berrange@redhat.com \
--cc=cheptsov@ispras.ru \
--cc=dme@dme.org \
--cc=imammedo@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).