From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: thuth@redhat.com, frankja@linux.ibm.com, david@redhat.com,
mst@redhat.com, richard.henderson@linaro.org,
qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
pbonzini@redhat.com, marcandre.lureau@redhat.com,
imbrenda@linux.ibm.com
Subject: Re: [PATCH v2 1/1] s390x: css: report errors from ccw_dstream_read/write
Date: Fri, 9 Apr 2021 12:27:57 +0200 [thread overview]
Message-ID: <20210409122757.5e0e182d.cohuck@redhat.com> (raw)
In-Reply-To: <1617899529-9329-2-git-send-email-pmorel@linux.ibm.com>
On Thu, 8 Apr 2021 18:32:09 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> ccw_dstream_read/write functions returned values are sometime
> not taking into account and reported back to the upper level
> of interpretation of CCW instructions.
>
> It follows that accessing an invalid address does not trigger
> a subchannel status program check to the guest as it should.
>
> Let's test the return values of ccw_dstream_write[_buf] and
> ccw_dstream_read[_buf] and report it to the caller.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> hw/char/terminal3270.c | 11 +++++--
> hw/s390x/3270-ccw.c | 5 +++-
> hw/s390x/css.c | 14 +++++----
> hw/s390x/virtio-ccw.c | 66 ++++++++++++++++++++++++++++++------------
> 4 files changed, 69 insertions(+), 27 deletions(-)
Thanks, queued to s390-fixes (with cc:stable added.)
next prev parent reply other threads:[~2021-04-09 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:32 [PATCH v2 0/1] s390x: css: report errors from ccw_dstream_read/write Pierre Morel
2021-04-08 16:32 ` [PATCH v2 1/1] " Pierre Morel
2021-04-09 8:38 ` Halil Pasic
2021-04-09 8:49 ` Cornelia Huck
2021-04-09 9:55 ` Pierre Morel
2021-04-09 10:11 ` Cornelia Huck
2021-04-09 10:27 ` Cornelia Huck [this message]
2021-04-09 10:32 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409122757.5e0e182d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).