Re: [PATCH v3] hw/block/nvme: add device self test command support

[Gollu Appalanaidu <anaidu.gollu@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

On Mon, Apr 12, 2021 at 01:57:49PM +0530, Gollu Appalanaidu wrote:
>On Sat, Apr 10, 2021 at 12:35:20AM +0900, Keith Busch wrote:
>>On Wed, Mar 31, 2021 at 02:54:27PM +0530, Gollu Appalanaidu wrote:
>>>This is to add support for Device Self Test Command (DST) and
>>>DST Log Page. Refer NVM Express specification 1.4b section 5.8
>>>("Device Self-test command")
>>
>>Please don't write change logs that just say what you did. I can read
>>the code to see that. Explain why this is useful because this frankly
>>looks like another useless feature. We don't need to implement every
>>optional spec feature here. There should be a real value proposition.
>>
>Hi Keith,
>It was useful to us to be able to test the feature against qemu - and
>we wanted to contribute the code, but we understand that features should
>be more "complete" for upstreaming.
>
>New features for SPDK (and nvme-cli) are use-cases for optional features
>like this, where one might not have physical device available and also users
>who is going to develop their in house host test tool this would be useful,
>since we are providing the functional behaviour as per the NVMe protocol.

Hi Keith,

It was useful to us to be able to test the feature against qemu - and
we wanted to contribute the code, but we understand that features should
be more "complete" for upstreaming.

New features for SPDK (and nvme-cli) are use-cases for optional features
like this, where one might not have physical device available and also users
who is going to develop their in house host test tool this would be useful,
since we are providing the functional behaviour as per the NVMe protocol.

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]